Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Open Liberty icon option #3146

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Add Open Liberty icon option #3146

merged 1 commit into from
Sep 9, 2019

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Sep 9, 2019

I mocked a template that uses the new icon-openliberty iconClass for the purposes of the screenshots below:

Screen Shot 2019-09-09 at 10 01 55 AM
Screen Shot 2019-09-09 at 10 02 38 AM
Screen Shot 2019-09-09 at 10 02 47 AM

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2019
spadgett
spadgett approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit 411f20b into openshift:enterprise-3.11 Sep 9, 2019
@rhamilto rhamilto deleted the openliberty-logo branch September 9, 2019 14:55
@ivandov ivandov mentioned this pull request Oct 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhamilto @spadgett @openshift-ci-robot @openshift-merge-robot