Bug 1721428: Remove misleading "Metrics might not be available" warning #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@spadgett: This pull request references a valid Bugzilla bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/L
|
/lgtm |
|
/retest |
A metrics URL is not required to use HPAs. Since we can't reliably detect whether metrics server is configured, remove the misleading warning that might show up when HPAs will otherwise work. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1721428
spadgett
force-pushed
the
metrics-warning
branch
from
25a5715 to
b5bdb7b
Compare
|
Passed CI... @rhamilto can you tag again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A metrics URL is not required to use HPAs. Since we can't reliably
detect whether metrics server is configured, remove the misleading
warning that might show up when HPAs will otherwise work.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1721428
/assign @rhamilto