Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1717028: Fix edge case evaluating services for deployment config #3131

Merged

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Jun 5, 2019

Include labels automatically added to deployment config pods since the service might select them.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1717028

/assign @rhamilto

Include labels automatically added to deployment config pods since the
service might select them.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1717028
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 5, 2019
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit a820396 into openshift:enterprise-3.11 Jun 5, 2019
@spadgett spadgett deleted the overview-dc-labels branch June 5, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants