[enterprise-3.11] Fix bug where cannot create new role and new rolebinding in single operation using template #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
rhamilto
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
spadgett
reviewed
Feb 7, 2019
|
/test |
|
/retest |
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
openshift-ci-robot
added
size/L
|
/test |
…le operation using template
rhamilto
commented
Feb 19, 2019
| let routesPage = new RoutesPage(project); | ||
| routesPage.visit(); | ||
| expect(element(by.cssContainingText('td', 'nodejs-mongodb-example')).isPresent()).toBe(true); // TODO: use fixture | ||
| return browser.sleep(3000).then(() => { |
There was a problem hiding this comment.
@spadgett, I took a guess this would resolve the failing test issue. Mind taking a look?
There was a problem hiding this comment.
This seems reasonable. Ideally we would wait for the page to update instead of an arbitrary sleep, but I think it's OK if it unblocks CI.
spadgett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1673109
Big assist from @spadgett on this one. Thank you!