Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where Membership nav item disappears #3110

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Fix bug where Membership nav item disappears #3110

merged 1 commit into from
Jan 24, 2019
+2 −0

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Jan 24, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2019
spadgett
spadgett approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2019
@rhamilto
Copy link
Member Author

D'oh. Needs dist.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2019
spadgett
spadgett approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4404b90 into openshift:enterprise-3.11 Jan 24, 2019
@spadgett spadgett mentioned this pull request Jan 24, 2019
Closed
@rhamilto rhamilto deleted the issue-1120 branch January 25, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhamilto @spadgett @openshift-ci-robot @openshift-merge-robot