Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enterprise-3.9] Lock datatables dependency #3030

Merged
merged 1 commit into from
Jun 18, 2018
Merged

[enterprise-3.9] Lock datatables dependency #3030

merged 1 commit into from
Jun 18, 2018

Conversation

spadgett
Copy link
Member

Backport of #3028

/assign @benjaminapetersen

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 18, 2018
benjaminapetersen
benjaminapetersen approved these changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This is a dependency of a dependency, right? Definitely one of those situations where I wish package.json supported comments :/

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2018
@openshift-merge-robot openshift-merge-robot merged commit 3774719 into openshift:enterprise-3.9 Jun 18, 2018
@spadgett spadgett deleted the 3.9-lock-datatables branch June 19, 2018 13:19
@spadgett
Copy link
Member Author

This is a dependency of a dependency, right? Definitely one of those situations where I wish package.json supported comments :/

Yeah, it's brought in by Patternfly. We're not using it directly.

@benjaminapetersen
Copy link
Contributor

Pondering if we should have put it in resolutions, to kind-of document this. Annoying, but bower isn't super robust.

Prob no matter, hopefully we will have few changes here anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

Assignees

@benjaminapetersen benjaminapetersen

Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spadgett @benjaminapetersen @openshift-ci-robot @openshift-merge-robot