Change project deletion confirmation message #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
spadgett
reviewed
Mar 15, 2018
| @@ -14,7 +14,7 @@ <h1 class="modal-title">Are you sure you want to delete the project '<strong>{{p | |||
| undone</strong>. Make sure this is something you really want to do! | |||
| </p> | |||
| <div ng-show="typeNameToConfirm"> | |||
| <p>Type the name of the project to confirm.</p> | |||
| <p>Type <strong>{{project | displayName}}</strong> to confirm deletion.</p> | |||
There was a problem hiding this comment.
I might suggest
Type <strong>{{project.metadata.name}}</strong> to confirm deletion.Either name or display name will work, but name is probably easier to type. Also two projects can have the same display name, whereas name is unambiguous.
|
@rhamilto LGTM |
spadgett
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports openshift/origin-web-console#2864
cc: @beanh66