Skip to content

Position so ui-select overlays when appended to body. #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2017
Merged

Position so ui-select overlays when appended to body. #243

merged 1 commit into from
Nov 3, 2017

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Nov 3, 2017

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 3, 2017
@rhamilto rhamilto requested a review from spadgett November 3, 2017 15:01
jwforres
jwforres approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@jwforres jwforres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending confirmation that this was tested with ui-select inside a dialog

@rhamilto
Copy link
Member

rhamilto commented Nov 3, 2017

lgtm pending confirmation that this was tested with ui-select inside a dialog

Yep. That's the exact case @sg00dwin is fixing.

@rhamilto rhamilto merged commit 467093a into openshift:master Nov 3, 2017
@sg00dwin sg00dwin deleted the ui-select-append-to-body branch November 6, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@spadgett spadgett spadgett approved these changes

@jwforres jwforres jwforres approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sg00dwin @rhamilto @spadgett @jwforres @openshift-ci-robot