[release-4.14] OCPBUGS-45080: SSA for Services and ClusterRoleBindings #905

dtfranz · 2024-12-03T20:22:12Z

Manual cherry-pick of #707 due to conflicts

openshift-ci-robot · 2024-12-03T20:22:18Z

@dtfranz: This pull request references Jira Issue OCPBUGS-45080, which is invalid:

expected the bug to target the "4.14.z" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-45080 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick of #707 due to conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dtfranz · 2024-12-05T00:48:28Z

Getting some possible flakes - e2e has failed twice now but on different tests. Running them again.

dtfranz · 2024-12-05T21:16:09Z

/jira refresh

openshift-ci-robot · 2024-12-05T21:16:16Z

@dtfranz: This pull request references Jira Issue OCPBUGS-45080, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-30141 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-30141 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2024-12-06T04:11:32Z

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-45080
/label qe-approved
/label cherry-pick-approved

openshift-ci-robot · 2024-12-06T04:11:39Z

@dtfranz: This pull request references Jira Issue OCPBUGS-45080, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-30141 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-30141 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

In response to this:

Manual cherry-pick of #707 due to conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianzhangbjz · 2024-12-06T04:11:40Z

/lgtm

jianzhangbjz · 2024-12-09T01:18:30Z

cc: @LalatenduMohanty @joelanford ^^

joelanford · 2024-12-09T13:50:29Z

staging/operator-lifecycle-manager/pkg/controller/install/certresources.go

+	crbLabels := map[string]string{OLMManagedLabelKey: OLMManagedLabelValue}
+	for key, val := range ownerutil.OwnerLabel(i.owner, i.owner.GetObjectKind().GroupVersionKind().Kind) {
+		crbLabels[key] = val
+	}


In 4.14, these labels are not used, right? (We added them, and then setup informers to use them in 4.15 iirc).

I don't think it necessarily hurts anything to include them in 4.14. But I want to at least ask the question: should we? Only real concern I can think of is that presence of this label may make someone think that it is used for something.

Thanks @joelanford ! I've removed them.

… SSA in order to avoid race conditions. (#3182) Signed-off-by: Daniel Franz <dfranz@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: dc0c564f62d526bae0467d53f439e1c91a17ed8a

openshift-ci · 2024-12-09T22:29:10Z

@dtfranz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jianzhangbjz · 2024-12-10T02:15:58Z

Retest it, pass.
/lgtm

perdasilva · 2024-12-10T16:32:00Z

/approve
/label backport-risk-assessed

openshift-ci · 2024-12-10T16:32:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtfranz, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-12-10T16:39:17Z

@dtfranz: Jira Issue OCPBUGS-45080: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#905

Jira Issue OCPBUGS-45080 has been moved to the MODIFIED state.

In response to this:

Manual cherry-pick of #707 due to conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-12-10T18:19:04Z

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.14.0-202412101706.p0.g82dc3f9.assembly.stream.el8.
All builds following this will include this PR.

openshift-bot · 2024-12-10T18:19:05Z

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.14.0-202412101706.p0.g82dc3f9.assembly.stream.el8.
All builds following this will include this PR.

openshift-merge-robot · 2024-12-10T22:58:54Z

Fix included in accepted release 4.14.0-0.nightly-2024-12-10-184304

openshift-ci bot requested review from anik120 and kevinrizza December 3, 2024 20:22

dtfranz force-pushed the service-ssa-4.14 branch from b2fa933 to d434c7e Compare December 3, 2024 20:43

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 5, 2024

openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Dec 6, 2024

openshift-ci bot assigned jianzhangbjz Dec 6, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024

joelanford reviewed Dec 9, 2024

View reviewed changes

dtfranz force-pushed the service-ssa-4.14 branch from d434c7e to b85a236 Compare December 9, 2024 18:56

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024

dtfranz force-pushed the service-ssa-4.14 branch from b85a236 to 4fc2da1 Compare December 9, 2024 18:57

Modify installation steps for ClusterRoleBindings and Services to use…

dfa1234

… SSA in order to avoid race conditions. (#3182) Signed-off-by: Daniel Franz <dfranz@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: dc0c564f62d526bae0467d53f439e1c91a17ed8a

dtfranz force-pushed the service-ssa-4.14 branch from 4fc2da1 to dfa1234 Compare December 9, 2024 19:23

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 10, 2024

openshift-ci bot assigned bandrade, emmajiafan, KeenonLee, kuiwang02 and Xia-Zhao-rh Dec 10, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024

openshift-merge-bot bot merged commit 82dc3f9 into openshift:release-4.14 Dec 10, 2024
13 checks passed

[release-4.14] OCPBUGS-45080: SSA for Services and ClusterRoleBindings #905

[release-4.14] OCPBUGS-45080: SSA for Services and ClusterRoleBindings #905

Uh oh!

Conversation

dtfranz commented Dec 3, 2024

Uh oh!

openshift-ci-robot commented Dec 3, 2024

Uh oh!

dtfranz commented Dec 5, 2024

Uh oh!

dtfranz commented Dec 5, 2024

Uh oh!

openshift-ci-robot commented Dec 5, 2024

Uh oh!

jianzhangbjz commented Dec 6, 2024

Uh oh!

openshift-ci-robot commented Dec 6, 2024

Uh oh!

jianzhangbjz commented Dec 6, 2024

Uh oh!

jianzhangbjz commented Dec 9, 2024

Uh oh!

joelanford Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

dtfranz Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Dec 9, 2024

Uh oh!

jianzhangbjz commented Dec 10, 2024

Uh oh!

perdasilva commented Dec 10, 2024

Uh oh!

openshift-ci bot commented Dec 10, 2024

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 10, 2024

Uh oh!

openshift-bot commented Dec 10, 2024

Uh oh!

openshift-bot commented Dec 10, 2024

Uh oh!

openshift-merge-robot commented Dec 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants