[release-4.16] OCPBUGS-44802: fix: call TokenRequest API when service account token secret is missing #900
Conversation
…ng (#3377) * fix: call TokenRequest API when service account token secret is missing Beyond Kubernetes 1.22, the service account token secret is not automatically, created. Therefore, when OLM is not able to find the service account token secret, it should request one from the k8s api server. Ref: https://kubernetes.io/docs/reference/access-authn-authz/service-accounts-admin/#manual-secret-management-for-serviceaccounts Signed-off-by: Edmund Ochieng <ochienged@gmail.com> * fix: return error Signed-off-by: Edmund Ochieng <ochienged@gmail.com> * handle error when creating sa token from TokenRequest API fails Signed-off-by: Edmund Ochieng <ochienged@gmail.com> * move return from inner loop Move the return to line 48. This will ensure a value is returned whether we successully create a service account token from the TokenRequest API or get an error Signed-off-by: Edmund Ochieng <ochienged@gmail.com> --------- Signed-off-by: Edmund Ochieng <ochienged@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: e20778cbb590f82dbe9cba500e98e7317222e5b5
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-44760 has been cloned as Jira Issue OCPBUGS-44802. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-44802, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned
bandrade,
emmajiafan,
jianzhangbjz,
KeenonLee,
kuiwang02 and
Xia-Zhao-rh
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
|
@grokspawn: This pull request references Jira Issue OCPBUGS-44802, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/lgtm |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@Xia-Zhao-rh: This pull request references Jira Issue OCPBUGS-44802, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit d718c4c
into
openshift:release-4.16
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-44802: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-44802 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: operator-lifecycle-manager |
|
[ART PR BUILD NOTIFIER] Distgit: operator-registry |
|
[ART PR BUILD NOTIFIER] Distgit: ose-operator-framework-tools |
12 participants
This is an automated cherry-pick of #898
/assign grokspawn