Bug 1975543: Use CVO to delete manifests removed from OLM #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into openshift:master from awgreene:bz-1975543

Mar 4, 2022

Contributor

awgreene commented Jan 24, 2022

Problem: Over the course of OLM's lifecycle resources
included in the CVO payload have been removed. CVO does
not automatically removed these resources from the cluster
unless they are properly annotated.

Solution: Reintroduce the removed manifests and include the
annotation that informs CVO to delete the resources.

Contributor Author

awgreene commented Jan 24, 2022

I need to check if CVO supports nested directories in the /manifest dir.
/hold

awgreene changed the title ~~Use CVO to delete manifests removed from OLM~~ Bug 1975543: Use CVO to delete manifests removed from OLM

openshift-ci bot added the bugzilla/severity-low label

Contributor

openshift-ci bot commented Jan 24, 2022

@awgreene: This pull request references Bugzilla bug 1975543, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1975543: Use CVO to delete manifests removed from OLM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/invalid-bug do-not-merge/hold labels

openshift-ci bot requested review from ankitathomas and perdasilva

January 24, 2022 20:28

openshift-ci bot added the approved label

Contributor Author

awgreene commented Jan 24, 2022

/bugzilla refresh

openshift-ci bot added bugzilla/valid-bug and removed bugzilla/invalid-bug labels

Contributor

openshift-ci bot commented Jan 24, 2022

@awgreene: This pull request references Bugzilla bug 1975543, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested a review from jianzhangbjz

January 24, 2022 20:30

awgreene commented

View reviewed changes

manifests/removed/0000_50_olm_16-packageserver.clusterserviceversion.yaml Show resolved Hide resolved

awgreene force-pushed the bz-1975543 branch from 14f531d to b703a6c Compare

January 24, 2022 20:50

Contributor Author

awgreene commented Jan 25, 2022

/retest

1 similar comment

Contributor Author

awgreene commented Jan 25, 2022

/retest

Contributor Author

awgreene commented Jan 25, 2022

/unhold

openshift-ci bot removed the do-not-merge/hold label

Contributor Author

awgreene commented Jan 25, 2022

/retest


          Use CVO to delete manifests removed from OLM

Problem: Over the course of OLM's lifecycle resources
included in the CVO payload have been removed. CVO does
not automatically removed these resources from the cluster
unless they are properly annotated.

Solution: Reintroduce the removed manifests and include the
annotation that informs CVO to delete the resources.

awgreene force-pushed the bz-1975543 branch from ebb4d45 to 7012367 Compare

January 26, 2022 14:57

Contributor Author

awgreene commented Jan 26, 2022

/retest

5 similar comments

Contributor Author

awgreene commented Jan 26, 2022

/retest

Contributor Author

awgreene commented Jan 27, 2022

/retest

Contributor Author

awgreene commented Jan 27, 2022

/retest

Contributor Author

awgreene commented Jan 28, 2022

/retest

Contributor Author

awgreene commented Jan 28, 2022

/retest

Contributor

openshift-bot commented Jan 28, 2022

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on master branch need to target OCP 4.11), recalculating validity.

Contributor

openshift-bot commented Mar 2, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

20 similar comments

Contributor

openshift-bot commented Mar 2, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 2, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 3, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Mar 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-ci bot commented Mar 4, 2022

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot merged commit 494df5a into openshift:master

Contributor

openshift-ci bot commented Mar 4, 2022

@awgreene: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#245

Bugzilla bug 1975543 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1975543: Use CVO to delete manifests removed from OLM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva added a commit to perdasilva/operator-framework-olm that referenced this pull request


          Refactor removed_api_tests to tests against sorted strings to avoid f…

3ce9495

…lakiness (openshift#245)

* Revert "fix removed_apis_test"

This reverts commit beb9613e0dc43e74ddcc583dfca3e59dd19c2660.

* refactor removed_apis_test to test on sorted error strings to remove flakiness

Signed-off-by: perdasilva <perdasilva@redhat.com>
Upstream-repository: api
Upstream-commit: cb9dc0ee2c6a5c31e04ce1ab0c2eee72d9125ffb

perdasilva added a commit to perdasilva/operator-framework-olm that referenced this pull request


          Refactor removed_api_tests to tests against sorted strings to avoid f…

a6de3ea

…lakiness (openshift#245)

* Revert "fix removed_apis_test"

This reverts commit beb9613e0dc43e74ddcc583dfca3e59dd19c2660.

* refactor removed_apis_test to test on sorted error strings to remove flakiness

Signed-off-by: perdasilva <perdasilva@redhat.com>
Upstream-repository: api
Upstream-commit: cb9dc0ee2c6a5c31e04ce1ab0c2eee72d9125ffb

perdasilva added a commit to perdasilva/operator-framework-olm that referenced this pull request


          Refactor removed_api_tests to tests against sorted strings to avoid f…

6faa0e2

…lakiness (openshift#245)

* Revert "fix removed_apis_test"

This reverts commit beb9613e0dc43e74ddcc583dfca3e59dd19c2660.

* refactor removed_apis_test to test on sorted error strings to remove flakiness

Signed-off-by: perdasilva <perdasilva@redhat.com>
Upstream-repository: api
Upstream-commit: cb9dc0ee2c6a5c31e04ce1ab0c2eee72d9125ffb

perdasilva added a commit to dinhxuanvu/operator-framework-olm that referenced this pull request


          Refactor removed_api_tests to tests against sorted strings to avoid f…

277973d

…lakiness (openshift#245)

* Revert "fix removed_apis_test"

This reverts commit beb9613e0dc43e74ddcc583dfca3e59dd19c2660.

* refactor removed_apis_test to test on sorted error strings to remove flakiness

Signed-off-by: perdasilva <perdasilva@redhat.com>
Upstream-repository: api
Upstream-commit: cb9dc0ee2c6a5c31e04ce1ab0c2eee72d9125ffb
Signed-off-by: perdasilva <perdasilva@redhat.com>

perdasilva added a commit to perdasilva/operator-framework-olm that referenced this pull request


          Refactor removed_api_tests to tests against sorted strings to avoid f…

71bbdfe

…lakiness (openshift#245)

* Revert "fix removed_apis_test"

This reverts commit beb9613e0dc43e74ddcc583dfca3e59dd19c2660.

* refactor removed_apis_test to test on sorted error strings to remove flakiness

Signed-off-by: perdasilva <perdasilva@redhat.com>
Upstream-repository: api
Upstream-commit: cb9dc0ee2c6a5c31e04ce1ab0c2eee72d9125ffb
Signed-off-by: perdasilva <perdasilva@redhat.com>

lance5890 mentioned this pull request

NO-JIRA: Remove deleted yamls #1032

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ankitathomas Awaiting requested review from ankitathomas

perdasilva Awaiting requested review from perdasilva

jianzhangbjz Awaiting requested review from jianzhangbjz

2 more reviewers

timflannagan timflannagan left review comments

dinhxuanvu dinhxuanvu approved these changes

Labels

approved bugzilla/severity-low bugzilla/valid-bug lgtm