OCPBUGS-64724: Fix TOCTOU race condition in ensureInstallPlan (#3682)

[jianzhangbjz]

Manually cherry-pick #1129

[openshift-ci-robot]

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-64724, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-64724 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manually cherry-pick #1129

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianzhangbjz
Once this PR has been reviewed and has the lgtm label, please assign oceanc80 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jianzhangbjz]

/jira refresh

[openshift-ci-robot]

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-64724, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jianzhangbjz]

/jira refresh

[openshift-ci-robot]

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-64724, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.z) matches configured target version for branch (4.20.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-63436 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-63436 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jianzhangbjz]

It failed, as the below shows: do we really need this checking? Thanks!

---
Detected go.mod in /go/src/github.com/openshift/operator-framework-olm; verifying vendored dependencies.
	github.com/openshift/api v3.9.0+incompatible
ERROR: Detected github.com/openshift/api or client-go v3.9.0+incompatible in go.mod
Do not use this 'version' of openshift/api or client-go . For complex
reasons, this invalid version is a contagion which causes modules
which import your code to also import the invalid version.
Fix:
Use an explicit commit in your 'require' statement. You can do
this with 'go get github.com/openshift/api@latest' or just specify
the import directly. For example, for openshift/api require:
        github.com/openshift/api@v0.0.0-20250710004639-926605d3338b
In addition, remove any 'replace' statement that may have been in
use for the module.
Unfortunately, this will be necessary until modules you require
eliminate their own use of v3.9.0+incompatible import.
Detail: v3.9.0+incompatible used to be a valid version/tag. However
managing @latest via tags was not desired, so the version was deleted.
Before that deletion, many modules had incorporated the now invalid
version. Since the version is greater than v0.0.0 pseudo-versions,
go 'upgrades' importing go.mods to use v3.9.0+incompatible and the
contagion spreads.
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-11-06T09:15:57Z"}
error: failed to execute wrapped command: exit status 1
---

[openshift-ci]

@jianzhangbjz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-deps	1a69e4f	link	true	/test verify-deps
ci/prow/okd-scos-e2e-aws-ovn	1a69e4f	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.