Skip to content

OCPBUGS-49759: Revert "[release-4.18] OCPBUGS-49715: CA cert and catalog cache bug fixes" #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

OCPBUGS-49759: Revert "[release-4.18] OCPBUGS-49715: CA cert and catalog cache bug fixes" #129

merged 2 commits into from
Feb 3, 2025

Conversation

@oceanc80
Copy link
Contributor

@oceanc80 oceanc80 commented Feb 3, 2025

Reverts #128 due to failing singlenode jobs noted in

TRT-1985

Testing with
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 3, 2025
@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-49759, which is invalid:

  • expected dependent Jira Issue OCPBUGS-49760 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #128 due to failing singlenode jobs noted in

TRT-1985

Testing with
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oceanc80

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@oceanc80
Copy link
Contributor Author

oceanc80 commented Feb 3, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 3, 2025
@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-49759, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-49760 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-49760 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@oceanc80
Copy link
Contributor Author

oceanc80 commented Feb 3, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 3, 2025
@openshift-ci openshift-ci bot requested a review from Xia-Zhao-rh February 3, 2025 18:20
@oceanc80
UPSTREAM: <drop>: Revert "UPSTREAM: <drop>: Separate CA configuration…
73952b2 
… for pulls vs catalogd services (#1673)"

This reverts commit ab7ec24.
@oceanc80 oceanc80 force-pushed the revert-128-4.18-ocpbugs-49683 branch from b5ded03 to 79f35c6 Compare February 3, 2025 18:24
@oceanc80
UPSTREAM: <carry>: Revert "UPSTREAM: <carry>: use projected volume fo…
79f35c6 
…r CAs to avoid subPath limitations"

This reverts commit 5be8f94.
@dtfranz
Copy link
Contributor

dtfranz commented Feb 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@joelanford
Copy link
Member

/test images

@bandrade
Copy link

bandrade commented Feb 3, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e9ad8c7 into release-4.18 Feb 3, 2025
8 of 9 checks passed
@openshift-ci-robot
Copy link

@oceanc80: Jira Issue OCPBUGS-49759: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-49759 has not been moved to the MODIFIED state.

In response to this:

Reverts #128 due to failing singlenode jobs noted in

TRT-1985

Testing with
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 3, 2025
Merged
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-catalogd
This PR has been included in build ose-olm-catalogd-container-v4.18.0-202502032101.p0.ge9ad8c7.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@perdasilva perdasilva Awaiting requested review from perdasilva

@Xia-Zhao-rh Xia-Zhao-rh Awaiting requested review from Xia-Zhao-rh

Assignees

@bandrade bandrade

@dtfranz dtfranz

@jianzhangbjz jianzhangbjz

@emmajiafan emmajiafan

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@KeenonLee KeenonLee

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.