-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-1726: Port the "Installing log storage" sections to 5.8 and 6… #94423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSDOCS-1726: Port the "Installing log storage" sections to 5.8 and 6… #94423
Conversation
@theashiot: This pull request references OBSDOCS-1726 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Tue Jun 17 15:06:21 - Prow CI generated the docs preview: https://94423--ocpdocs-pr.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Deploying a Loki log store on a cluster that uses short-term credentials" section contains duplicated information from the "Install Log Store" that should be removed.
139fe88
to
dae433a
Compare
removed |
/lgtm |
Thanks, @JoaoBraveCoding! |
Hi @anpingli, @kabirbhartiRH, @QiaolingTang, can you please provide a QE review for the changes? thanks, |
/lgtm |
Thanks, @kabirbhartiRH! |
@theashiot: This pull request references OBSDOCS-1726 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label peer-review-required |
@theashiot: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice migration! A couple issues I would address in the ccoctl
intro, and otherwise just some docs plumbing that should accompany this type of work
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done
[id="installing-log-storage-loki-sts"] | ||
=== Deploying a Loki log store on a cluster that uses short-term credentials | ||
|
||
For some storage providers, you can use the CCO utility (`ccoctl`) during installation to implement short-term credentials. These credentials are created and managed outside the {ocp-product-title} cluster. link:https://docs.openshift.com/container-platform/latest/authentication/managing_cloud_provider_credentials/cco-short-term-creds.adoc#cco-short-term-creds[Manual mode with short-term credentials for components]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some storage providers, you can use the CCO utility (`ccoctl`) during installation to implement short-term credentials. These credentials are created and managed outside the {ocp-product-title} cluster. link:https://docs.openshift.com/container-platform/latest/authentication/managing_cloud_provider_credentials/cco-short-term-creds.adoc#cco-short-term-creds[Manual mode with short-term credentials for components]. | |
For some storage providers, you can use the Cloud Credential Operator utility (`ccoctl`) during installation to implement short-term credentials. These credentials are created and managed outside the {ocp-product-title} cluster. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/authentication_and_authorization/managing-cloud-provider-credentials#cco-short-term-creds[Manual mode with short-term credentials for components]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every module in this assembly should be updated to have the assembly listed under
// Module included in the following assemblies:
And if they are no longer included in e.g. configuring/configuring-lokistack-storage.adoc
, that line should be removed from the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I know that's a pain!
dae433a
to
52d65a2
Compare
New changes are detected. LGTM label has been removed. |
0217378
to
67889fe
Compare
Thanks, @jeana-redhat for the review! best, |
/label merge-review-needed |
@theashiot: This pull request references OBSDOCS-1726 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I would fix the filename in the metadata just to avoid future confusion.
// | ||
// * logging/log_storage/installing-log-storage.adoc | ||
// * configuring/configuring-the-log-storage.adoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like filename is configuring-the-log-store and not configuring-the-log-storage? Not a big deal but could be confusing for someone unfamiliar with the docs so I would fix this in the modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
67889fe
to
61a696a
Compare
@theashiot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thanks, @kcarmichael08 for the review! I've updated the file name in all the relevant modules. |
b5f1ebe
into
openshift:standalone-logging-docs-main
/cherrypick standalone-logging-docs-6.3 |
/cherrypick standalone-logging-docs-6.2 |
standalone-logging-docs-6.1 |
/cherrypick standalone-logging-docs-6.1 |
@kcarmichael08: new pull request created: #94860 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick standalone-logging-docs-6.0 |
@kcarmichael08: new pull request created: #94861 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kcarmichael08: #94423 failed to apply on top of branch "standalone-logging-docs-6.1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kcarmichael08: #94423 failed to apply on top of branch "standalone-logging-docs-6.0":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 6.0+
Issue: https://issues.redhat.com/browse/OBSDOCS-1726
Link to docs preview: https://94423--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html
QE review:
Additional information: To be cherry-picked to: standalone-logging-docs-6.3, standalone-logging-docs-6.2, standalone-logging-docs-6.1, standalone-logging-docs-6.0