MCO add info on upgrade ack for updated boot images #94207

mburke5678 · 2025-06-03T20:18:44Z

https://issues.redhat.com/browse/OSDOCS-14891

During upgrade from 4.18 to 4.19, on GCP and AWS clusters, if there is no configuration of the managedBootImages in the the MachineConfiguration object, the upgrade is blocked. The user needs to disable managed boot images or perform an admin-ack. The error message that accompanies the pause has a hard-coded link to the "Disabling updated boot images" module in the 4.18 docs. This PR adds information to that specific version on how to restart the upgrade.

DO NOT MERGE UNTIL 4.19 GAs

Preview: Disabling updated boot images -- See NOTE

QE review:

QE has approved this change.

ocpdocs-previewbot · 2025-06-03T20:35:06Z

🤖 Tue Jun 10 18:10:30 - Prow CI generated the docs preview:

https://94207--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/mco-update-boot-images.html
https://94207--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/nodes/nodes-nodes-managing.html

mburke5678 · 2025-06-04T15:09:08Z

@ptalgulk01 Can you take a look, please?

djoshy · 2025-06-05T13:24:06Z

modules/mco-update-boot-images-disable.adoc

+
+To start the update, perform one of the following tasks:
+
+* If you do not want the updated boot image feature enabled, explicitly disable the feature as described in this section.


Suggested change

* If you do not want the updated boot image feature enabled, explicitly disable the feature as described in this section.

* If you do not want the managed boot images feature enabled, explicitly disable the feature as described in this section.

@djoshy I will look into changing the name to match 4.19 in a separate PR.

"this section" might be confusing. I was expecting a link but then I assumed it's "Disabling updated boot images" steps. How about:

explicitly disable the feature as described in the "Disabling updated boot images" procedure.

ptalgulk01 · 2025-06-06T05:28:02Z

looks good

modules/mco-update-boot-images-disable.adoc

dfitzmau · 2025-06-06T13:07:16Z

modules/mco-update-boot-images-disable.adoc

+
+To start the update, perform one of the following tasks:
+
+* If you do not want the updated boot image feature enabled, explicitly disable the feature as described in this section.


"this section" might be confusing. I was expecting a link but then I assumed it's "Disabling updated boot images" steps. How about:

explicitly disable the feature as described in the "Disabling updated boot images" procedure.

modules/mco-update-boot-images-disable.adoc

djoshy · 2025-06-09T13:46:06Z

modules/mco-update-boot-images-disable.adoc

+====
+If you are upgrading a {GCP} or {AWS} cluster from {product-title} 4.18 to 4.19, and you have not configured the `managedBootImages` parameter, the upgrade is blocked with the _This cluster is GCP or AWS but lacks a boot image configuration._ message. The update is blocked intentionally in order to alert you that the default updated boot image behavior is changing between version 4.18 and 4.19 to enable updated boot images by default.
+
+To restart the update, perform one of the following tasks:


Want to clarify one more thing here, since I have a feeling I may have mislead you. To upgrade the cluster after you receive this message, you have to do one of the following steps and then the oc command you typically do to start the upgrade.

@djoshy What triggers this message? When and where do I see it?

Here is an example(for a different admin-ack)
https://redhat-internal.slack.com/archives/C02CZNQHGN8/p1749047989998549?thread_ts=1749047987.686429&cid=C02CZNQHGN8

Suggested change

To restart the update, perform one of the following tasks:

To allow the update, perform one of the following tasks:

The message shows up before the upgrade it proposed and inhibits the update until acknowledged. BTW did we test that disabling the feature removes the admin ack requirement once it's already been created?

Yes, that was tested when we worked on openshift/machine-config-operator#5027

wking · 2025-06-09T16:04:23Z

modules/mco-update-boot-images-disable.adoc

@@ -9,6 +9,21 @@

 To disable the updated boot image feature, edit the `MachineConfiguration` object so that the `machineManagers` field is an empty array.

+[NOTE]
+====
+If you are updating a {GCP} or {AWS} cluster from {product-title} 4.18 to 4.19, and you have not configured the `managedBootImages` parameter, the update is blocked with a _This cluster is GCP or AWS but lacks a boot image configuration._ message. The update is blocked intentionally in order to alert you that the default updated boot image behavior is changing between version 4.18 and 4.19 to enable updated boot images by default.


Maybe

Suggested change

If you are updating a {GCP} or {AWS} cluster from {product-title} 4.18 to 4.19, and you have not configured the `managedBootImages` parameter, the update is blocked with a _This cluster is GCP or AWS but lacks a boot image configuration._ message. The update is blocked intentionally in order to alert you that the default updated boot image behavior is changing between version 4.18 and 4.19 to enable updated boot images by default.

If you are updating a {GCP} or {AWS} cluster from {product-title} 4.18 to 4.19, and you have not configured the `managedBootImages` parameter, the update is blocked with a _This cluster is GCP or AWS but lacks a boot image configuration._ message. The update is blocked intentionally in order to alert you that the default updated boot image behavior is changing between version 4.18 and 4.19 to enable updated boot images by default on those platforms.

or something that makes it more clear in that sentence that we're only talking about AWS/GCP, even for folks who skim past the opening of this paragraph?

wking · 2025-06-09T16:09:13Z

modules/mco-update-boot-images-disable.adoc

+
+To allow the update, perform one of the following tasks:
+
+* If you do not want the updated boot image feature enabled, explicitly disable the feature by using the following procedure.


nit: can we flip the order of these two list entries? First, I think we prefer the MCO management, because it conveniently keeps things current in the cluster, and opening with our preferred option saves the folks taking that path some reading. Second, it makes the "using the following procedure" more clearly "the following Procedure subsection about editing the MachineConfiguration", when it feels like the current ordering might have some readers confuse this to mean "the admin-acks patch in the following list entry".

@wking PTAL: 381f89b

openshift-ci · 2025-06-10T18:11:42Z

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mburke5678 added this to the Continuous Release milestone Jun 3, 2025

mburke5678 added the branch/enterprise-4.18 label Jun 3, 2025

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2025

mburke5678 changed the title ~~MCO add info on upgrade pause for updated boot images~~ MCO add info on upgrade block for updated boot images Jun 4, 2025

djoshy reviewed Jun 5, 2025

View reviewed changes

mburke5678 force-pushed the mco-boot-image-admin-ack branch 2 times, most recently from 73be813 to beed966 Compare June 6, 2025 11:59

mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 6, 2025

dfitzmau added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 6, 2025

dfitzmau approved these changes Jun 6, 2025

View reviewed changes

dfitzmau added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 6, 2025

mburke5678 changed the title ~~MCO add info on upgrade block for updated boot images~~ MCO add info on upgrade ack for updated boot images Jun 9, 2025

mburke5678 force-pushed the mco-boot-image-admin-ack branch from beed966 to c8c0fb2 Compare June 9, 2025 12:29

mburke5678 added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 9, 2025

mburke5678 force-pushed the mco-boot-image-admin-ack branch from c8c0fb2 to 1292bbb Compare June 9, 2025 13:15

djoshy reviewed Jun 9, 2025

View reviewed changes

wking reviewed Jun 9, 2025

View reviewed changes

MCO add info on upgrade pause for updated boot images

99e0a30

mburke5678 force-pushed the mco-boot-image-admin-ack branch from 381f89b to 99e0a30 Compare June 10, 2025 17:41

mburke5678 merged commit 96a7878 into openshift:enterprise-4.18 Jun 10, 2025
2 checks passed

mburke5678 deleted the mco-boot-image-admin-ack branch June 10, 2025 18:12


		To start the update, perform one of the following tasks:

		* If you do not want the updated boot image feature enabled, explicitly disable the feature as described in this section.

	* If you do not want the updated boot image feature enabled, explicitly disable the feature as described in this section.
	* If you do not want the managed boot images feature enabled, explicitly disable the feature as described in this section.

	To restart the update, perform one of the following tasks:
	To allow the update, perform one of the following tasks:

MCO add info on upgrade ack for updated boot images #94207

MCO add info on upgrade ack for updated boot images #94207

Uh oh!

Conversation

mburke5678 commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mburke5678 commented Jun 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ptalgulk01 commented Jun 6, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

mburke5678 commented Jun 3, 2025 •

edited

Loading

ocpdocs-previewbot commented Jun 3, 2025 •

edited

Loading