Skip to content

HCIDOCS-699: Missing documentation for BMO configuration #92567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

HCIDOCS-699: Missing documentation for BMO configuration #92567

merged 1 commit into from
May 13, 2025

Conversation

johnwilkins
Copy link
Contributor

@johnwilkins johnwilkins commented Apr 23, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2025 •
edited by openshift-ci bot
Loading

@johnwilkins: This pull request references HCIDOCS-699 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

ContentX reorganization of bare metal postinstallation and expansing docs.

Fixes: HCIDOCS-699

See https://issues.redhat.com/browse/HCIDOCS-699 for additional details.

Preview URL: http://jowilkin.com:8080/HCIDOCS-699/welcome/index.html

For release(s): 4.18-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 23, 2025 •
edited
Loading

🤖 Tue May 13 17:11:27 - Prow CI generated the docs preview:
https://92567--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2025 •
edited by openshift-ci bot
Loading

@johnwilkins: This pull request references HCIDOCS-699 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

ContentX reorganization of bare metal postinstallation and expansing docs.

Fixes: HCIDOCS-699

See https://issues.redhat.com/browse/HCIDOCS-699 for additional details.

Preview URL: https://92567--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/bare-metal-postinstallation-configuration and https://92567--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/bare-metal-expanding-the-cluster.html

For release(s): 4.18-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2025 •
edited by openshift-ci bot
Loading

@johnwilkins: This pull request references HCIDOCS-699 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

ContentX reorganization of bare metal postinstallation and expansing docs.

Fixes: HCIDOCS-699

See https://issues.redhat.com/browse/HCIDOCS-699 for additional details.

Preview URL: https://92567--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/bare-metal-postinstallation-configuration and https://92567--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/bare-metal-expanding-the-cluster.html

For release(s): 4.18-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@johnwilkins
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 9, 2025
@Chin2691
Copy link
Contributor

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 12, 2025

@Chin2691: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 13, 2025
@lpettyjo lpettyjo self-requested a review May 13, 2025 12:42
@lpettyjo lpettyjo added this to the Continuous Release milestone May 13, 2025
lpettyjo
lpettyjo reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple commits. They need to be squashed to one commit. Let me know if you have any questions about doing that.

Otherwise, LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 13, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2025
@johnwilkins
HCIDOCS-699: Raised postinstallation configuration and expanding the …
14dc0af 
…cluster to same level as UPI/IPI, since the procedures are not exclusive to IPI..
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 13, 2025

@johnwilkins: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@johnwilkins
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 13, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 13, 2025
jeana-redhat
jeana-redhat approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

/remove-label merge-review-in-progress
/remove-label merge-review-needed

installing/installing_bare_metal/bare-metal-expanding-the-cluster.adoc
Comment on lines +21 to +22
* See xref:../../installing/installing_bare_metal/ipi/ipi-install-installation-workflow.adoc#configuring-host-network-interfaces-in-the-install-config-yaml-file_ipi-install-installation-workflow[Optional: Configuring host network interfaces in the install-config.yaml file] for details on configuring the NMState syntax.
* See xref:../../scalability_and_performance/managing-bare-metal-hosts.adoc#automatically-scaling-machines-to-available-bare-metal-hosts_managing-bare-metal-hosts[Automatically scaling machines to the number of available bare-metal hosts] for details on automatically scaling machines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is existing content and unrelated to your work here, maybe come back to fix the format for these some time?

Suggested change
* See xref:../../installing/installing_bare_metal/ipi/ipi-install-installation-workflow.adoc#configuring-host-network-interfaces-in-the-install-config-yaml-file_ipi-install-installation-workflow[Optional: Configuring host network interfaces in the install-config.yaml file] for details on configuring the NMState syntax.
* See xref:../../scalability_and_performance/managing-bare-metal-hosts.adoc#automatically-scaling-machines-to-available-bare-metal-hosts_managing-bare-metal-hosts[Automatically scaling machines to the number of available bare-metal hosts] for details on automatically scaling machines.
* xref:../../installing/installing_bare_metal/ipi/ipi-install-installation-workflow.adoc#configuring-host-network-interfaces-in-the-install-config-yaml-file_ipi-install-installation-workflow[Optional: Configuring host network interfaces in the install-config.yaml file]
* xref:../../scalability_and_performance/managing-bare-metal-hosts.adoc#automatically-scaling-machines-to-available-bare-metal-hosts_managing-bare-metal-hosts[Automatically scaling machines to the number of available bare-metal hosts]

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 13, 2025
@jeana-redhat jeana-redhat merged commit 1f81a03 into openshift:main May 13, 2025
2 checks passed
@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.19

@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #93324

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@jeana-redhat: #92567 failed to apply on top of branch "enterprise-4.18":

Applying: HCIDOCS-699: Raised postinstallation configuration and expanding the cluster to same level as UPI/IPI, since the procedures are not exclusive to IPI..
.git/rebase-apply/patch:116: trailing whitespace.
* xref:../../installing/installing_bare_metal/bare-metal-postinstallation-configuration.adoc#bmo-config-using-bare-metal-operator_bare-metal-postinstallation-configuration[Configuration using the Bare Metal Operator]                                                                      
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	installing/installing_bare_metal/ipi/ipi-install-post-installation-configuration.adoc
M	modules/ipi-install-replacing-a-bare-metal-control-plane-node.adoc
M	post_installation_configuration/cluster-tasks.adoc
Falling back to patching base and 3-way merge...
Auto-merging post_installation_configuration/cluster-tasks.adoc
Auto-merging modules/ipi-install-replacing-a-bare-metal-control-plane-node.adoc
Removing installing/installing_bare_metal/ipi/ipi-install-expanding-the-cluster.adoc
Auto-merging installing/installing_bare_metal/bare-metal-postinstallation-configuration.adoc
CONFLICT (content): Merge conflict in installing/installing_bare_metal/bare-metal-postinstallation-configuration.adoc
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 HCIDOCS-699: Raised postinstallation configuration and expanding the cluster to same level as UPI/IPI, since the procedures are not exclusive to IPI..

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 13, 2025
Merged
@jeana-redhat
Copy link
Contributor

@johnwilkins sorry to report you'll need to manually port this to 4.18 - will merge 4.19 when it's ready

@johnwilkins johnwilkins mentioned this pull request Jun 19, 2025
Open
1 task
johnwilkins added a commit to johnwilkins/openshift-docs that referenced this pull request Jun 20, 2025
@johnwilkins
HCIDOCS-699-4.18: This PR is a manual cherry pick of openshift#92567..
abc3154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpettyjo lpettyjo lpettyjo left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@jeana-redhat jeana-redhat jeana-redhat approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@johnwilkins @openshift-ci-robot @ocpdocs-previewbot @Chin2691 @jeana-redhat @openshift-cherrypick-robot @lpettyjo @ocpdocs-vale-bot @openshift-merge-robot