Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-8740 Document full list of SMCP CR -> Istio CR fields mapping #88602

Open
wants to merge 1 commit into
base: service-mesh-docs-main
Choose a base branch
from

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Feb 14, 2025

OSSM 3.0 GA

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main

Cherry pick: to https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0

https://issues.redhat.com/browse/OSSM-8740

This PR is part of the standalone doc set for the OpenShift Service Mesh project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

Version(s):
OSSM 3.0 is moving to stand alone format and will not be cherry-picked back to OCP core branches.

Issue:
https://issues.redhat.com/browse/OSSM-8740

Link to docs preview:
https://88602--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/reference/ossm-migrating-reference-assembly.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 14, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 14, 2025

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2025
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 14, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2025
Copy link
Contributor

@jewertow jewertow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand why fields for 2.6 are not prefixed with spec. like those for 3.0. I would suggest to add spec. prefix to all fields in the column for 2.6, or remove it from 3.0. I prefer the second option.

@FilipB
Copy link

FilipB commented Feb 17, 2025

I do not understand why fields for 2.6 are not prefixed with spec. like those for 3.0. I would suggest to add spec. prefix to all fields in the column for 2.6, or remove it from 3.0. I prefer the second option.

I assume it was because of Many of the ServiceMeshControlPlane spec. configuration fields in the text. Suggesting that all listed fields belong under spec field. I would vote for first option suggested by Jacek so it's full path. Or go with second option but add a note about all fields belong under spec

@gwynnemonahan
Copy link
Contributor Author

Hey @FilipB and @jewertow ,

That's now how they are here: https://github.com/openshift-service-mesh/sail-operator/blob/main/docs/ossm/ossm2-migration/smcp-fields-migration/smcp-to-istio-mappings.md#field-mappings-smcp-26-to-istio-30 which is the source of truth so that is how they were copied over.

I can make updates.

Copy link

openshift-ci bot commented Feb 20, 2025

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants