-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-8740 Document full list of SMCP CR -> Istio CR fields mapping #88602
base: service-mesh-docs-main
Are you sure you want to change the base?
OSSM-8740 Document full list of SMCP CR -> Istio CR fields mapping #88602
Conversation
🤖 Thu Feb 20 16:06:27 - Prow CI generated the docs preview: |
c20b524
to
b86e290
Compare
750ac04
to
5707077
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand why fields for 2.6 are not prefixed with spec.
like those for 3.0. I would suggest to add spec.
prefix to all fields in the column for 2.6, or remove it from 3.0. I prefer the second option.
I assume it was because of |
That's now how they are here: https://github.com/openshift-service-mesh/sail-operator/blob/main/docs/ossm/ossm2-migration/smcp-fields-migration/smcp-to-istio-mappings.md#field-mappings-smcp-26-to-istio-30 which is the source of truth so that is how they were copied over. I can make updates. |
modules/ossm-migrating-reference-unsupported-configurations.adoc
Outdated
Show resolved
Hide resolved
3fb1863
to
eb81f07
Compare
525cd20
to
2b58652
Compare
@gwynnemonahan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
OSSM 3.0 GA
Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick: to https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0
https://issues.redhat.com/browse/OSSM-8740
This PR is part of the standalone doc set for the OpenShift Service Mesh project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.
Version(s):
OSSM 3.0 is moving to stand alone format and will not be cherry-picked back to OCP core branches.
Issue:
https://issues.redhat.com/browse/OSSM-8740
Link to docs preview:
https://88602--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/reference/ossm-migrating-reference-assembly.html
QE review:
Additional information: