Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROX-27692] Using Scanner to create SBOM #88601

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[ROX-27692] Using Scanner to create SBOM #88601

merged 1 commit into from
Feb 20, 2025
+151 −3

Conversation

kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Feb 13, 2025 •
edited
Loading

Version(s):

4.7

Issue

Link to docs preview

QE review: ACS has no QE, approved by SME

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2025
@kcarmichael08 kcarmichael08 added rhacs-docs-4.7 RHACS Label for RHACS related PRs that go in the rhacs-docs branch labels Feb 13, 2025
@kcarmichael08 kcarmichael08 added this to the Continuous Release milestone Feb 13, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 13, 2025 •
edited
Loading

🤖 Wed Feb 19 23:12:26 - Prow CI generated the docs preview:

https://88601--ocpdocs-pr.netlify.app/openshift-acs/latest/cli/command-reference/roxctl-image.html
https://88601--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage-vulnerabilities/scanner-generate-sbom.html

@kcarmichael08 kcarmichael08 force-pushed the ROX-27692-sbom branch 5 times, most recently from 3de2327 to 49d1ea4 Compare February 18, 2025 15:21
dcaravel
dcaravel reviewed Feb 19, 2025
View reviewed changes
@BradLugo
Copy link

I want to echo @dcaravel's point about clarifying the current capabilities of RHACS-generated SBOMs: #88601 (comment)

Everything else looks good to me!

@kcarmichael08 kcarmichael08 added rhacs-docs-4.7 RHACS Label for RHACS related PRs that go in the rhacs-docs branch peer-review-needed Signifies that the peer review team needs to review this PR and removed RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.7 labels Feb 19, 2025
@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed
/assign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 19, 2025
GroceryBoyJr
GroceryBoyJr reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question.

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 19, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 19, 2025

@kcarmichael08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 merged commit 7872779 into openshift:rhacs-docs-main Feb 20, 2025
2 checks passed
@kcarmichael08
Copy link
Contributor Author

/cherrypick rhacs-docs-4.7

@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #88961

In response to this:

/cherrypick rhacs-docs-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@dcaravel dcaravel dcaravel left review comments

Assignees
No one assigned
Labels
peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.7 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@kcarmichael08 @ocpdocs-previewbot @BradLugo @GroceryBoyJr @openshift-cherrypick-robot @dcaravel