Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added information about logging login failures #8694

Merged
merged 1 commit into from
May 11, 2018

Conversation

ahardin-rh
Copy link
Contributor

https://bugzilla.redhat.com/show_bug.cgi?id=1545116

@soltysh Does this adequately capture what you suggest in the BZ discussion? PTAL. Thanks!

@ahardin-rh ahardin-rh added this to the Next Release milestone Apr 11, 2018
@ahardin-rh ahardin-rh self-assigned this Apr 11, 2018
@ahardin-rh ahardin-rh requested a review from soltysh April 11, 2018 21:01
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2018
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit and you're good to go :)

@@ -1284,6 +1290,8 @@ that group.
<5> A list of groups the rule applies to. An empty list implies every group.
<6> A list of non-resources URLs the rule applies to.
<7> A list of namespaces the rule applies to. An empty list implies every namespace.
<8> Value used by the web console.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/value/endpoint

@ahardin-rh ahardin-rh force-pushed the audit-policy-config branch from 0063795 to afe948e Compare April 12, 2018 13:19
@ahardin-rh ahardin-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 12, 2018
@ahardin-rh
Copy link
Contributor Author

Moving this to QE review. @openshift/team-documentation Please also peer review. Thanks!

@@ -1261,6 +1261,12 @@ rules:

# A catch-all rule to log all other requests at the Metadata level.
- level: Metadata <1>

# Log login failures from the web console or CLI. Turn on the audit, then create policy based on the requested data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If both methods are required or encouraged, it should be "webconsole and CLI"

"Turn on the audit, then create policy based on the requested data." doesn't fit here. I might change it to a note to review the logs and refine your policies, as required, around line 1187.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or is because you can log either, each rule applies to a different element. Let's be explicit about it.

@@ -1284,6 +1290,8 @@ that group.
<5> A list of groups the rule applies to. An empty list implies every group.
<6> A list of non-resources URLs the rule applies to.
<7> A list of namespaces the rule applies to. An empty list implies every namespace.
<8> Endpoint used by the web console.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this enough information for a user to construct the endpoints?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, what else we can add here. It's basically an information that this endpoint is where the logging from web console are going through.

@ahardin-rh
Copy link
Contributor Author

@kalexand-rh Thanks for your comments. @soltysh Thoughts on that feedback?

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 26, 2018
@ahardin-rh ahardin-rh changed the title Added information about lgging login failures Added information about logging login failures May 11, 2018
@ahardin-rh ahardin-rh force-pushed the audit-policy-config branch from afe948e to af7afa0 Compare May 11, 2018 18:10
@ahardin-rh
Copy link
Contributor Author

QE verified in the BZ

@ahardin-rh ahardin-rh merged commit 07e84da into openshift:master May 11, 2018
@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-3.10

@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-3.9

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #9215

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #9216

In response to this:

/cherrypick enterprise-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.7 branch/enterprise-3.9 branch/enterprise-3.10 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants