-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-12533: ABI on OCI GA #84551
base: main
Are you sure you want to change the base?
OSDOCS-12533: ABI on OCI GA #84551
Conversation
@skopacz1: This pull request references OSDOCS-12533 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Tue Nov 12 17:25:24 - Prow CI generated the docs preview: |
@@ -8,6 +8,8 @@ toc::[] | |||
|
|||
In {product-title} {product-version}, you can use the Agent-based Installer to install a cluster on {oci-first}, so that you can run cluster workloads on infrastructure that supports dedicated, hybrid, public, and multiple cloud environments. | |||
|
|||
Installing a cluster on {oci} is supported for both virtual machines (VMs) and bare metal machines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'bare-metal machines' rather than 'bare metal machines'. For more information, see RedHat.TermsErrors.
In the |
@@ -95,13 +101,19 @@ pullSecret: '<pull_secret>' <6> | |||
Do not move the `install-config.yaml` and `agent-config.yaml` configuration files to the `openshift` directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the step on line 97: If it was valid to add a step about creating an installation directory earlier, should this openshift
directory be a subdirectory of that?
.. Change the `oci-cloud-controller-manager` secret that is defined in the `oci-ccm.yml` configuration file to match your organization's region, compartment {ocid}, VCN {ocid}, and the subnet {ocid} from the load balancer. | ||
|
||
. Use the Agent-based Installer to generate a minimal ISO image, which excludes the rootfs image, by entering the following command in your {product-title} CLI. You can use this image later in the process to boot all your cluster’s nodes. | ||
. Generate a minimal ISO image, which excludes the rootfs image, by entering the following command. You can use this image later in the process to boot all your cluster's nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to my other question - if adding the installation directory step was valid, should this command have an argument to specify that dir? Or, alternatively, should I mention in the wording that you need to run this in your installation directory?
6a02b8e
to
7aef7a2
Compare
@skopacz1: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
OSDOCS-12533
Version(s): 4.17+
This PR makes updates to add GA support for Agent-based installs on Oracle.
QE review:
Previews: Installing a cluster on Oracle Cloud Infrastructure by using the Agent-based Installer