Skip to content

OCPBUGS#33927: Add long-lived token/secret step to OLM policy scoping #82232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

OCPBUGS#33927: Add long-lived token/secret step to OLM policy scoping #82232

merged 1 commit into from
Oct 4, 2024

Conversation

@adellape
Copy link
Contributor

@adellape adellape commented Sep 20, 2024 •
edited
Loading

https://issues.redhat.com/browse/OCPBUGS-33927

Preview:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2024
@adellape
Copy link
Contributor Author

adellape commented Sep 20, 2024

/test validate-asciidoc

@adellape adellape force-pushed the osdk_sa branch 2 times, most recently from d303dbc to 5355753 Compare September 20, 2024 18:31
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 20, 2024 •
edited
Loading

🤖 Mon Sep 30 15:36:56 - Prow CI generated the docs preview:

https://82232--ocpdocs-pr.netlify.app/openshift-enterprise/latest/operators/admin/olm-creating-policy.html

@adellape adellape added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.16 branch/enterprise-4.17 labels Sep 20, 2024
@adellape adellape added this to the Continuous Release milestone Sep 20, 2024
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 20, 2024
@adellape adellape force-pushed the osdk_sa branch 2 times, most recently from e744dc6 to f96cef1 Compare September 20, 2024 19:38
@adellape adellape changed the title OCPBUGS#33927: Add secret step to OLM policy scoping OCPBUGS#33927: Add long-lived token/secret step to OLM policy scoping Sep 20, 2024
mburke5678
mburke5678 reviewed Sep 20, 2024
View reviewed changes
mburke5678
mburke5678 reviewed Sep 20, 2024
View reviewed changes
mburke5678
mburke5678 reviewed Sep 20, 2024
View reviewed changes
mburke5678
mburke5678 reviewed Sep 20, 2024
View reviewed changes
mburke5678
mburke5678 reviewed Sep 20, 2024
View reviewed changes
mburke5678
mburke5678 reviewed Sep 20, 2024
View reviewed changes
mburke5678
mburke5678 reviewed Sep 20, 2024
View reviewed changes
mburke5678
mburke5678 reviewed Sep 20, 2024
View reviewed changes
@mburke5678
Copy link
Contributor

mburke5678 commented Sep 20, 2024

@adellape A few suggestions. Otherwise LGTM

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 20, 2024
@adellape adellape force-pushed the osdk_sa branch 2 times, most recently from 2a053e8 to 7fed615 Compare September 22, 2024 01:11
@Xia-Zhao-rh
Copy link

Xia-Zhao-rh commented Sep 24, 2024

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2024

@adellape: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adellape adellape merged commit 1485e08 into openshift:main Oct 4, 2024
@adellape adellape deleted the osdk_sa branch October 4, 2024 20:50
@adellape
Copy link
Contributor Author

adellape commented Oct 4, 2024

/cherrypick enterprise-4.18

@adellape
Copy link
Contributor Author

adellape commented Oct 4, 2024

/cherrypick enterprise-4.17

@adellape
Copy link
Contributor Author

adellape commented Oct 4, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 4, 2024

@adellape: new pull request created: #83106

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 4, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 4, 2024

@adellape: new pull request created: #83107

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 4, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 4, 2024

@adellape: new pull request created: #83108

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

5 participants

@adellape @ocpdocs-previewbot @mburke5678 @Xia-Zhao-rh @openshift-cherrypick-robot