Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enterprise-4.17] CNV#40187-02: Misc RN Fix #82066

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[enterprise-4.17] CNV#40187-02: Misc RN Fix #82066

merged 1 commit into from
Sep 19, 2024

Conversation

danielclowers
Copy link
Contributor

@danielclowers danielclowers commented Sep 18, 2024 •
edited
Loading

Version(s):
4.17

Issue:
https://issues.redhat.com/browse/CNV-40187

Link to docs preview:
https://82066--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-17-release-notes.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 18, 2024 •
edited by openshift-ci bot
Loading

@danielclowers: No Jira issue with key 40187-02 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.17

Issue:
https://issues.redhat.com/browse/CNV-40187

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

@danielclowers: No Jira issue with key 40187-02 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.17

Issue:
https://issues.redhat.com/browse/CNV-40187

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 18, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 18, 2024 •
edited
Loading

🤖 Wed Sep 18 19:23:26 - Prow CI generated the docs preview:

https://82066--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-17-release-notes.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 18, 2024 •
edited by openshift-ci bot
Loading

@danielclowers: No Jira issue with key 40187-02 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.17

Issue:
https://issues.redhat.com/browse/CNV-40187

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

@danielclowers: No Jira issue with key 40187-02 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.17

Issue:
https://issues.redhat.com/browse/CNV-40187

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danielclowers danielclowers changed the title CNV#40187-02: Misc RN Fix [enterprise-4.17] CNV#40187-02: Misc RN Fix Sep 18, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 18, 2024

@danielclowers: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 18, 2024 •
edited by openshift-ci bot
Loading

@danielclowers: No Jira issue with key 40187-02 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.17

Issue:
https://issues.redhat.com/browse/CNV-40187

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

@danielclowers: No Jira issue with key 40187-02 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.17

Issue:
https://issues.redhat.com/browse/CNV-40187

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danielclowers
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 18, 2024
@openshift-ci-robot
Copy link

@danielclowers: No Jira issue with key 40187-02 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.17

Issue:
https://issues.redhat.com/browse/CNV-40187

Link to docs preview:
https://82066--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-17-release-notes.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger JoeAldinger added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 18, 2024
JoeAldinger
JoeAldinger reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@JoeAldinger JoeAldinger added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR lgtm Indicates that a PR is ready to be merged. labels Sep 18, 2024
@JoeAldinger JoeAldinger removed their assignment Sep 18, 2024
@danielclowers
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 19, 2024
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

bergerhoffer
bergerhoffer reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for merging

@bergerhoffer bergerhoffer merged commit e2e63c9 into openshift:enterprise-4.17 Sep 19, 2024
2 checks passed
@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@JoeAldinger JoeAldinger JoeAldinger left review comments

Assignees
No one assigned
Labels
merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danielclowers @openshift-ci-robot @ocpdocs-previewbot @bergerhoffer @JoeAldinger