Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-1294 Observability UI plugins overview #81402

Merged
merged 1 commit into from
Sep 19, 2024
Merged

OBSDOCS-1294 Observability UI plugins overview #81402

merged 1 commit into from
Sep 19, 2024

Conversation

gabriel-rh
Copy link
Contributor

@gabriel-rh gabriel-rh commented Sep 5, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 5, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 5, 2024 •
edited
Loading

🤖 Wed Sep 18 14:18:15 - Prow CI generated the docs preview:

https://81402--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/cluster_observability_operator/ui_plugins/observability-ui-plugins-overview.html

@gabriel-rh
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 13, 2024
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Sep 16, 2024
View reviewed changes
observability/cluster_observability_operator/ui_plugins/observability-ui-plugins-overview.adoc Outdated

== Distributed tracing

The distributed tracing UI plugin adds tracing-related features to the {product-title} web console under *Observe* -> *Traces*.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{DTShortName}' rather than the plain text product term 'distributed tracing', unless your use case is an exception.

@abrennan89 abrennan89 self-requested a review September 16, 2024 14:02
@abrennan89 abrennan89 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 16, 2024
@abrennan89 abrennan89 added this to the Continuous Release milestone Sep 16, 2024
abrennan89
abrennan89 reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested comments and required updates. Nice work, @gabriel-rh !

@abrennan89 abrennan89 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 16, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 18, 2024

@gabriel-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp
Copy link

LGTM

@lihongyan1
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@gabriel-rh gabriel-rh merged commit 52aa37c into openshift:main Sep 19, 2024
2 checks passed
@gabriel-rh
Copy link
Contributor Author

/cherrypick enterprise-4.16

@gabriel-rh
Copy link
Contributor Author

/cherrypick enterprise-4.17

@gabriel-rh
Copy link
Contributor Author

/cherrypick enterprise-4.15

@gabriel-rh
Copy link
Contributor Author

/cherrypick enterprise-4.14

@gabriel-rh
Copy link
Contributor Author

/cherrypick enterprise-4.13

@gabriel-rh
Copy link
Contributor Author

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #82123

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 19, 2024
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #82124

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 19, 2024
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #82125

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 19, 2024
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #82126

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 19, 2024
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #82127

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 19, 2024
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #82128

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgbernalp jgbernalp jgbernalp left review comments

@abrennan89 abrennan89 abrennan89 left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees

@lihongyan1 lihongyan1

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 lgtm Indicates that a PR is ready to be merged. observability peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@gabriel-rh @ocpdocs-previewbot @jgbernalp @lihongyan1 @openshift-cherrypick-robot @abrennan89 @ocpdocs-vale-bot