I have added a commands to Export proxy variables for clear understan…

[cainneri]

…ding

I have made PR for adding commands to export proxy variables in the etcd backup process.

Version(s):
4.12+

Issue:
OCPBUGS-33384

Link to docs preview:
https://80848--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/control_plane_backup_and_restore/backing-up-etcd.html#backing-up-etcd-data_backup-etcd

QE review:

• QE has approved this change.

[openshift-ci]

Hi @cainneri. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lahinson]

/ok-to-test

[lahinson]

Hi @cainneri - I edited your proposed text according to the OpenShift doc guidelines.

[ocpdocs-previewbot]

🤖 Thu Sep 05 17:52:34 - Prow CI generated the docs preview:

https://80848--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/control_plane_backup_and_restore/backing-up-etcd.html
https://80848--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/cluster-tasks.html

[cainneri]

Hi @lahinson I have made required Changes. Kindly Please review and Let me know if i need to add anything further

[lahinson]

Hi @cainneri - As you can see in the docs preview, the formatting is still not quite right:

If you incorporate the rest of my suggested changes, I believe that should fix the formatting issues.

[cainneri]

hi @lahinson I have made required Changes. Kindly Please review and Let me know if i need to add anything further

[lahinson]

@cainneri In the preview, I see one very small formatting issue that needs to be fixed. Hopefully, it should be easy to fix. Thank you!

[lahinson]

I think the formatting issues will be resolved if you remove this line. For example, the text should look like this:

.. To export the `HTTP_PROXY`, `HTTPS_PROXY`, and `NO_PROXY` environment variables, run the following commands:
+
[source,terminal]
----
$ export HTTP_PROXY=http://<your_proxy.example.com>:8080
----
+
[source,terminal]
----
$ export HTTPS_PROXY=https://<your_proxy.example.com>:8080
----
+
[source,terminal]
----
$ export NO_PROXY=<example.com>
----

[lahinson]

Hi @cainneri - The formatting looks good now. I will add this to the queue for merge review. I noticed that you need to squash your commits. You will need to use the command line to do that. You can find the instructions here: https://docs.google.com/document/d/1fLMpK4bqthtFlCwA36yeo2cI-pExFpX76VMnSi_In6Q/edit#bookmark=id.9bn6glcn7tle

[jeana-redhat]

@cainneri thanks for this great addition to the docs!

As Laura mentioned, this needs to be squashed to a single commit before we can merge it. I have also left a small formatting fix on the file, but it should be straightforward to just copy and paste into the file.

Please copy over the suggested format fix, and then squash this to a single commit. We can help you get it merged from that point 🤓

/remove-label merge-review-in-progress
/remove-label merge-review-needed

[openshift-ci]

@cainneri: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bergerhoffer]

The branch/enterprise-4.18 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.17. And any PR going into main must also target the latest version branch (enterprise-4.18).

If the update in your PR does NOT apply to version 4.18 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale