Skip to content

Conversation

@dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Aug 12, 2024

Version(s):
4.12+

Issue:
OCPBUGS-38352

Link to docs preview:
Supported network plugin feature matrix - OVNK

  • SME has approved this change.
  • QE has approved this change.

Add info:

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 12, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-38352, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 12, 2024

🤖 Wed Sep 04 08:50:54 - Prow CI generated the docs preview:
https://80365--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2024
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2024
@dfitzmau dfitzmau force-pushed the OCPBUGS-38352 branch 2 times, most recently from 2a1ddd1 to fa2b247 Compare August 13, 2024 15:43
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2024
@dfitzmau dfitzmau force-pushed the OCPBUGS-38352 branch 4 times, most recently from 47f3f64 to 6614031 Compare August 15, 2024 10:41
@dfitzmau dfitzmau force-pushed the OCPBUGS-38352 branch 2 times, most recently from dbc0328 to 5cd534d Compare August 21, 2024 15:13
@dfitzmau dfitzmau changed the title OCPBUGS-38352: Updated the Supported network plugin feature matrix table OCPBUGS#38352: Updated the Supported network plugin feature matrix table Aug 21, 2024
@openshift-ci-robot openshift-ci-robot removed jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2024
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-38352

Link to docs preview:
Supported network plugin feature matrix - SDN
Supported network plugin feature matrix - OVNK

  • SME has approved this change.
  • QE has approved this change.

Add info:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1. Egress router for OVN-Kubernetes supports only redirect mode.
2. IPv6 is supported only on bare metal, vSphere, {ibm-power-name}, {ibm-z-name}, and Red Hat OpenStack clusters.
2. IPv6 single-stack networking is only supported on bare metal, {ibm-power-name}, {ibm-z-name}, and {rh-openstack-first} clusters. You must enable IPv6 access for your image registry to prevent network connectivity issues when you need to pull images from the registry.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not equivalent. I think the intent of the "IPv6" support was actually dual stack. Single stack only works on baremetal right now.

I think this needs to be rewritten to say this section is for dual stack and then the point below should be changed to say that IPv6 single stack is supported only on baremetal, instead of the exclusion list (which is technically not even complete now since IPv6 isn't supported on the cloud platforms either at this point).

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2024
@qiliRedHat
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2024
@dfitzmau
Copy link
Contributor Author

dfitzmau commented Sep 2, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 2, 2024
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 3, 2024
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tiny things caught my eye while scanning. Nothing crucial, lmk whether you want to address at this time.

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 3, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit c73da1f into openshift:main Sep 6, 2024
@dfitzmau
Copy link
Contributor Author

dfitzmau commented Sep 6, 2024

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Sep 6, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #81417

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Sep 6, 2024

/cherrypick enterprise-4.15

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Sep 6, 2024

/cherrypick enterprise-4.14

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Sep 6, 2024

/cherrypick enterprise-4.13

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Sep 6, 2024

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@dfitzmau: #80365 failed to apply on top of branch "enterprise-4.16":

Applying: OCPBUGS-38352: Updated the Supported network plugin feature matrix table
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
M	modules/nw-ovn-kubernetes-matrix.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/nw-ovn-kubernetes-matrix.adoc deleted in OCPBUGS-38352: Updated the Supported network plugin feature matrix table and modified in HEAD. Version HEAD of modules/nw-ovn-kubernetes-matrix.adoc left in tree.
Auto-merging _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-38352: Updated the Supported network plugin feature matrix table
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: #80365 failed to apply on top of branch "enterprise-4.15":

Applying: OCPBUGS-38352: Updated the Supported network plugin feature matrix table
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
M	modules/nw-ovn-kubernetes-matrix.adoc
M	networking/ovn_kubernetes_network_provider/about-ovn-kubernetes.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/ovn_kubernetes_network_provider/about-ovn-kubernetes.adoc
CONFLICT (modify/delete): modules/nw-ovn-kubernetes-matrix.adoc deleted in OCPBUGS-38352: Updated the Supported network plugin feature matrix table and modified in HEAD. Version HEAD of modules/nw-ovn-kubernetes-matrix.adoc left in tree.
Auto-merging _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-38352: Updated the Supported network plugin feature matrix table
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: #80365 failed to apply on top of branch "enterprise-4.14":

Applying: OCPBUGS-38352: Updated the Supported network plugin feature matrix table
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
M	modules/nw-ovn-kubernetes-matrix.adoc
M	networking/ovn_kubernetes_network_provider/about-ovn-kubernetes.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/ovn_kubernetes_network_provider/about-ovn-kubernetes.adoc
CONFLICT (modify/delete): modules/nw-ovn-kubernetes-matrix.adoc deleted in OCPBUGS-38352: Updated the Supported network plugin feature matrix table and modified in HEAD. Version HEAD of modules/nw-ovn-kubernetes-matrix.adoc left in tree.
Auto-merging _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-38352: Updated the Supported network plugin feature matrix table
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: #80365 failed to apply on top of branch "enterprise-4.13":

Applying: OCPBUGS-38352: Updated the Supported network plugin feature matrix table
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
M	modules/nw-ovn-kubernetes-matrix.adoc
M	networking/ovn_kubernetes_network_provider/about-ovn-kubernetes.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/ovn_kubernetes_network_provider/about-ovn-kubernetes.adoc
CONFLICT (modify/delete): modules/nw-ovn-kubernetes-matrix.adoc deleted in OCPBUGS-38352: Updated the Supported network plugin feature matrix table and modified in HEAD. Version HEAD of modules/nw-ovn-kubernetes-matrix.adoc left in tree.
Auto-merging _attributes/common-attributes.adoc
CONFLICT (content): Merge conflict in _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-38352: Updated the Supported network plugin feature matrix table
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: #80365 failed to apply on top of branch "enterprise-4.12":

Applying: OCPBUGS-38352: Updated the Supported network plugin feature matrix table
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
M	modules/nw-ovn-kubernetes-matrix.adoc
M	networking/ovn_kubernetes_network_provider/about-ovn-kubernetes.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/ovn_kubernetes_network_provider/about-ovn-kubernetes.adoc
CONFLICT (modify/delete): modules/nw-ovn-kubernetes-matrix.adoc deleted in OCPBUGS-38352: Updated the Supported network plugin feature matrix table and modified in HEAD. Version HEAD of modules/nw-ovn-kubernetes-matrix.adoc left in tree.
Auto-merging _attributes/common-attributes.adoc
CONFLICT (content): Merge conflict in _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-38352: Updated the Supported network plugin feature matrix table
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants