OSDOCS#9028: Selecting a single AZ in a multi AZ cluster for a machinepool #71679
Conversation
openshift-ci
bot
added
the
size/L
|
🤖 Thu Feb 29 17:11:28 - Prow CI generated the docs preview: |
fmcdonal
force-pushed
the
OSDOCS-9028
branch
from
8a1d65e to
a451f4b
Compare
openshift-ci
bot
added
size/XS
fmcdonal
changed the title
fmcdonal
changed the title
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
snarayan-redhat
added
peer-review-in-progress
snarayan-redhat
added
peer-review-done
|
LGTM |
|
@arendej can you confirm you are happy with change as QE has reviewed I am checking a few minor items with xue li and Ori but would like your confirmation also for this to be merged, thanks |
fmcdonal
force-pushed
the
OSDOCS-9028
branch
from
a451f4b to
c0a6a66
Compare
openshift-ci
bot
added
size/S
fmcdonal
force-pushed
the
OSDOCS-9028
branch
2 times, most recently
from
070c4b5 to
718fc6a
Compare
fmcdonal
force-pushed
the
OSDOCS-9028
branch
from
d3ab1a3 to
8c6b844
Compare
|
LGTM |
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
|
/remove-label merge-review-needed |
fmcdonal
force-pushed
the
OSDOCS-9028
branch
2 times, most recently
from
cadcd75 to
5c0991c
Compare
openshift-ci
bot
added
size/M
fmcdonal
force-pushed
the
OSDOCS-9028
branch
from
8c8674e to
1576642
Compare
openshift-ci
bot
added
size/M
fmcdonal
force-pushed
the
OSDOCS-9028
branch
from
ddfcb54 to
8f9ff99
Compare
adellape
added
the
merge-review-in-progress
…ng a machine pool"
fmcdonal
force-pushed
the
OSDOCS-9028
branch
from
8f9ff99 to
77b7259
Compare
|
@fmcdonal: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
||
| * To add a machine pool that does not use autoscaling, create the machine pool and define the instance type, compute (also known as worker) node count, and node labels: | ||
| + | ||
| -- |
There was a problem hiding this comment.
Noting for the future: Open blocks (the starting -- for one of them shown here on line 21, with the closing -- down on line 70) have been wrapped around both of the code blocks in this procedure, so that the callouts behave as expected (namely, allows for + multi-paragraph continuations and admonition blocks, without breaking callout number order or indentation).
| <7> Optional: If you choose to use Spot Instances, you can specify this argument to define a maximum hourly price for a Spot Instance. If this argument is not specified, the on-demand price is used. | ||
| + | ||
| [IMPORTANT] | ||
| ==== | ||
| Your Amazon EC2 Spot Instances might be interrupted at any time. Use Amazon EC2 Spot Instances only for workloads that can tolerate interruptions. | ||
| ==== |
There was a problem hiding this comment.
Also, Frances and I determined that this [IMPORTANT] admonition about Spot Instances had been incorrectly separated from its originally-intended callout over time (per Paul's original PR), so this PR also moves both instances of the admonition (here and below) up to where it should go, now that callouts are working correctly (thanks to the open blocks).
|
/cherrypick enterprise-4.16 |
|
/cherrypick enterprise-4.15 |
|
/cherrypick enterprise-4.14 |
|
@adellape: new pull request created: #72397 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adellape: new pull request created: #72398 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adellape: new pull request created: #72399 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
adellape
removed
the
merge-review-in-progress
10 participants
Version(s):
4.14+
Issue:
https://issues.redhat.com/browse/OSDOCS-9028
Link to docs preview:
https://71679--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes#creating_machine_pools_cli_rosa-managing-worker-nodes
QE review: