Skip to content

Conversation

@cbippley
Copy link
Contributor

@cbippley cbippley commented Feb 5, 2024

Version(s): 4.15

Issue: OSDOCS-9562

Link to docs preview: Preview

QE review:
Not needed

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2024
@ocpdocs-previewbot
Copy link

🤖 Mon Feb 05 20:20:16 - Prow CI generated the docs preview: https://71222--ocpdocs-pr.netlify.app

@openshift-ci
Copy link

openshift-ci bot commented Feb 5, 2024

@cbippley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbippley
Copy link
Contributor Author

cbippley commented Feb 5, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 5, 2024
@skopacz1
Copy link
Contributor

skopacz1 commented Feb 5, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 5, 2024
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skopacz1
Copy link
Contributor

skopacz1 commented Feb 5, 2024

/remove-label peer-review-needed
/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 5, 2024
@cbippley
Copy link
Contributor Author

cbippley commented Feb 6, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 6, 2024
@adellape adellape merged commit 2fb7228 into openshift:enterprise-4.15 Feb 6, 2024
@adellape adellape removed the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 6, 2024
@adellape adellape self-assigned this Feb 6, 2024
@adellape adellape added this to the Planned for 4.15 GA milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants