Skip to content

Conversation

@ShaunaDiaz
Copy link
Contributor

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/OSDOCS-8464

Link to docs preview:

QE review:

  • N/A, docs plumbing

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 2, 2023

@ShaunaDiaz: This pull request references OSDOCS-8464 which is a valid jira issue.

In response to this:

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/OSDOCS-8464

Link to docs preview:

QE review:

  • N/A, docs plumbing

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 2, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 2, 2023

🤖 Updated build preview is available at:
https://67345--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/31891

@ShaunaDiaz
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 3, 2023
@ShaunaDiaz
Copy link
Contributor Author

@JoeAldinger Could you also PTAL?

@JoeAldinger JoeAldinger added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 3, 2023
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small stuff, I wasn't sure how much you wanted to carryover and what should be // out, but it otherwise looks good.

@JoeAldinger JoeAldinger removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 3, 2023
@JoeAldinger JoeAldinger added this to the Planned for 4.15 GA milestone Nov 3, 2023
@JoeAldinger JoeAldinger added branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR labels Nov 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2023

@ShaunaDiaz: This pull request references OSDOCS-8464 which is a valid jira issue.

In response to this:

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/OSDOCS-8464

Link to docs preview:

QE review:

  • N/A, docs plumbing

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh closed this Nov 6, 2023
@kalexand-rh kalexand-rh reopened this Nov 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2023

@ShaunaDiaz: This pull request references OSDOCS-8464 which is a valid jira issue.

In response to this:

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/OSDOCS-8464

Link to docs preview:

QE review:

  • N/A, docs plumbing

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShaunaDiaz
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 6, 2023
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 6, 2023
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 6, 2023
@jeana-redhat jeana-redhat merged commit 5fd47a6 into openshift:enterprise-4.15 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants