Skip to content

BZ2103610 fixing taints, 9 BZs total #50662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2022
Merged

BZ2103610 fixing taints, 9 BZs total #50662

merged 1 commit into from
Sep 21, 2022

Conversation

@ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Sep 21, 2022 •
edited
Loading

This bug includes eight others and addresses an incorrect example in three modules. QE confirmed the reporter as correct in the first (#10) ticket.

Version(s):

  • PR applies to: 4.8+

Issues:
This fix (applied in three modules and several sections) is in reference to:

https://bugzilla.redhat.com/show_bug.cgi?id=2103610
https://bugzilla.redhat.com/show_bug.cgi?id=2103611
https://bugzilla.redhat.com/show_bug.cgi?id=2103612
https://bugzilla.redhat.com/show_bug.cgi?id=2103613
https://bugzilla.redhat.com/show_bug.cgi?id=2103614
https://bugzilla.redhat.com/show_bug.cgi?id=2103615
https://bugzilla.redhat.com/show_bug.cgi?id=2103616
https://bugzilla.redhat.com/show_bug.cgi?id=2103617
https://bugzilla.redhat.com/show_bug.cgi?id=2103618

Links to docs preview (not in order of bugs, in order they occur in docs for easier viewing):
https://50662--docspreview.netlify.app/openshift-enterprise/latest/nodes/scheduling/nodes-scheduler-taints-tolerations.html#nodes-scheduler-taints-tolerations-about_nodes-scheduler-taints-tolerations

https://50662--docspreview.netlify.app/openshift-enterprise/latest/nodes/scheduling/nodes-scheduler-taints-tolerations.html#nodes-scheduler-taints-tolerations-about-seconds_nodes-scheduler-taints-tolerations

https://50662--docspreview.netlify.app/openshift-enterprise/latest/nodes/scheduling/nodes-scheduler-taints-tolerations.html#nodes-scheduler-taints-tolerations-about-multiple_nodes-scheduler-taints-tolerations

https://50662--docspreview.netlify.app/openshift-enterprise/latest/nodes/scheduling/nodes-scheduler-taints-tolerations.html#nodes-scheduler-taints-tolerations-about-taintBasedEvictions_nodes-scheduler-taints-tolerations

https://50662--docspreview.netlify.app/openshift-enterprise/latest/nodes/scheduling/nodes-scheduler-taints-tolerations.html#nodes-scheduler-taints-tolerations-adding_nodes-scheduler-taints-tolerations

https://50662--docspreview.netlify.app/openshift-enterprise/latest/nodes/scheduling/nodes-scheduler-taints-tolerations.html#nodes-scheduler-taints-tolerations-adding-machineset_nodes-scheduler-taints-tolerations

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 21, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 21, 2022

🤖 Bots are busy building the preview. It will be available soon at:
https://50662--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/627

@ShaunaDiaz
Copy link
Contributor Author

ShaunaDiaz commented Sep 21, 2022

/label needs-peer-review

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2022

@ShaunaDiaz: The label(s) /label needs-peer-review cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, serverless, service-mesh, staff-eng-approved, telco

In response to this:

/label needs-peer-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShaunaDiaz
Copy link
Contributor Author

ShaunaDiaz commented Sep 21, 2022

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 21, 2022
@maxwelldb maxwelldb self-assigned this Sep 21, 2022
@maxwelldb maxwelldb self-requested a review September 21, 2022 18:31
@maxwelldb maxwelldb added this to the Continuous Release milestone Sep 21, 2022
@maxwelldb maxwelldb added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 21, 2022
@maxwelldb maxwelldb assigned ShaunaDiaz and unassigned maxwelldb Sep 21, 2022
@ShaunaDiaz
Copy link
Contributor Author

ShaunaDiaz commented Sep 21, 2022

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 21, 2022
@maxwelldb maxwelldb merged commit 614eccb into openshift:main Sep 21, 2022
@maxwelldb
Copy link
Contributor

maxwelldb commented Sep 21, 2022 •
edited
Loading

/cherry-pick enterprise-4.8
/cherry-pick enterprise-4.9
/cherry-pick enterprise-4.10
/cherry-pick enterprise-4.11
/cherry-pick enterprise-4.12

e: Guess we can't do multi-command comments for cherry-pick.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 21, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 21, 2022

@maxwelldb: new pull request created: #50667

In response to this:

/cherry-pick enterprise-4.8
/cherry-pick enterprise-4.9
/cherry-pick enterprise-4.10
/cherry-pick enterprise-4.11
/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb
Copy link
Contributor

maxwelldb commented Sep 21, 2022

/cherry-pick enterprise-4.9

@maxwelldb
Copy link
Contributor

maxwelldb commented Sep 21, 2022

/cherry-pick enterprise-4.10

@maxwelldb
Copy link
Contributor

maxwelldb commented Sep 21, 2022

/cherry-pick enterprise-4.11

@maxwelldb
Copy link
Contributor

maxwelldb commented Sep 21, 2022

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 21, 2022

@maxwelldb: new pull request created: #50669

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 21, 2022
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 21, 2022

@maxwelldb: new pull request created: #50670

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 21, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 21, 2022

@maxwelldb: new pull request created: #50671

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 21, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 21, 2022

@maxwelldb: new pull request created: #50672

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb maxwelldb removed the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 21, 2022
@ShaunaDiaz ShaunaDiaz deleted the BZ2103610 branch August 9, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxwelldb maxwelldb maxwelldb approved these changes

Assignees

@ShaunaDiaz ShaunaDiaz

Labels

branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

4 participants

@ShaunaDiaz @ocpdocs-previewbot @maxwelldb @openshift-cherrypick-robot