Skip to content

Conversation

@EricPonvelle
Copy link
Contributor

@EricPonvelle EricPonvelle commented May 6, 2022

Version(s):
Enterprise-4.9+

Issue:
OSDOCS-3599

Link to docs preview:
Before restructure

After restructure

Additional information:

This PR restructures the OpenShift Dedicated documentation to align with the ROSA restructure #41923/#43807.

@EricPonvelle EricPonvelle added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 labels May 6, 2022
@EricPonvelle EricPonvelle added this to the Next Release milestone May 6, 2022
@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 6, 2022
@EricPonvelle EricPonvelle force-pushed the OSDOCS-3599_OSD-Restructure branch from 17a05c5 to 18d0d12 Compare May 6, 2022 21:25
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 6, 2022
@EricPonvelle EricPonvelle force-pushed the OSDOCS-3599_OSD-Restructure branch from 18d0d12 to b0c1e20 Compare May 6, 2022 21:46
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 6, 2022
@EricPonvelle EricPonvelle force-pushed the OSDOCS-3599_OSD-Restructure branch from b0c1e20 to c5cae96 Compare May 6, 2022 22:29
@netlify
Copy link

netlify bot commented May 6, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit f78ed8a
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/62828043db7d4800080071c5
😎 Deploy Preview https://deploy-preview-45428--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@EricPonvelle EricPonvelle force-pushed the OSDOCS-3599_OSD-Restructure branch from c5cae96 to 69f6ffc Compare May 9, 2022 19:48
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 9, 2022
@EricPonvelle EricPonvelle force-pushed the OSDOCS-3599_OSD-Restructure branch 4 times, most recently from b39f5a0 to f36862a Compare May 9, 2022 21:10
Copy link
Contributor

@pneedle-rh pneedle-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricPonvelle this new library structure looks great, this is a fantastic job. The consistency with the ROSA library is really helpful for findability too.

I have added a couple of suggestions for reference in this PR directly, although they might be out of scope for the restructure and instead we could work on them later as a team.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we don't have pages on granting/revoking privileges and access or deleting an OSD cluster in the "Installing, accessing, and deleting OpenShift Dedicated clusters". Maybe we can reuse the modules that are in the OSD "Getting started" page (https://docs.openshift.com/dedicated/osd_quickstart/osd-quickstart.html) in an assembly on that topic for the time being in this section and then build it out with more detail that is provided in the "Getting started" at a later date.

This is something we can look at after the restructure.

@EricPonvelle EricPonvelle force-pushed the OSDOCS-3599_OSD-Restructure branch 3 times, most recently from fe0aa08 to 4b64e2f Compare May 16, 2022 16:35
@EricPonvelle EricPonvelle force-pushed the OSDOCS-3599_OSD-Restructure branch from 4b64e2f to f78ed8a Compare May 16, 2022 16:48
@lpettyjo lpettyjo self-requested a review May 16, 2022 18:52
@lpettyjo lpettyjo added the peer-review-needed Signifies that the peer review team needs to review this PR label May 16, 2022
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checked links and LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 17, 2022
@EricPonvelle EricPonvelle merged commit 67ffc70 into openshift:main May 19, 2022
@EricPonvelle
Copy link
Contributor Author

/cherrypick enterprise-4.10

@EricPonvelle
Copy link
Contributor Author

/cherrypick enterprise-4.11

@EricPonvelle
Copy link
Contributor Author

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #45876

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #45877

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: #45428 failed to apply on top of branch "enterprise-4.9":

Applying: OSD Restructure
error: mode change for administering_a_cluster/_attributes, which is not in current HEAD
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSD Restructure
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EricPonvelle EricPonvelle deleted the OSDOCS-3599_OSD-Restructure branch May 19, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 branch/enterprise-4.11 do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants