-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OSDOCS-3599] OSD Restructure #45428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSDOCS-3599] OSD Restructure #45428
Conversation
17a05c5 to
18d0d12
Compare
18d0d12 to
b0c1e20
Compare
b0c1e20 to
c5cae96
Compare
✅ Deploy Preview for osdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
c5cae96 to
69f6ffc
Compare
b39f5a0 to
f36862a
Compare
pneedle-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EricPonvelle this new library structure looks great, this is a fantastic job. The consistency with the ROSA library is really helpful for findability too.
I have added a couple of suggestions for reference in this PR directly, although they might be out of scope for the restructure and instead we could work on them later as a team.
_topic_maps/_topic_map_osd.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that we don't have pages on granting/revoking privileges and access or deleting an OSD cluster in the "Installing, accessing, and deleting OpenShift Dedicated clusters". Maybe we can reuse the modules that are in the OSD "Getting started" page (https://docs.openshift.com/dedicated/osd_quickstart/osd-quickstart.html) in an assembly on that topic for the time being in this section and then build it out with more detail that is provided in the "Getting started" at a later date.
This is something we can look at after the restructure.
fe0aa08 to
4b64e2f
Compare
4b64e2f to
f78ed8a
Compare
lpettyjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot checked links and LGTM!
|
/cherrypick enterprise-4.10 |
|
/cherrypick enterprise-4.11 |
|
/cherrypick enterprise-4.9 |
|
@EricPonvelle: new pull request created: #45876 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@EricPonvelle: new pull request created: #45877 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@EricPonvelle: #45428 failed to apply on top of branch "enterprise-4.9": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
Enterprise-4.9+
Issue:
OSDOCS-3599
Link to docs preview:
Before restructure
After restructure
Additional information:
This PR restructures the OpenShift Dedicated documentation to align with the ROSA restructure #41923/#43807.