Skip to content

Conversation

@emarcusRH
Copy link
Contributor

@emarcusRH emarcusRH commented Apr 6, 2022

Target - enterprise-4.11
https://issues.redhat.com/browse/OCPRHV-417
update GitHub resource URL and command for downloading installer Ansible playbooks

redoing to correct typos in the URLs and insert the correct attribute for the release version

Preview: https://deploy-preview-44233--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_rhv/installing-rhv-user-infra.html#installation-rhv-downloading-ansible-playbooks_installing-rhv-user-infra

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 6, 2022
@netlify
Copy link

netlify bot commented Apr 6, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit e6f73ec
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/624d7e65322c6d00088665a7
😎 Deploy Preview https://deploy-preview-44233--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@michalskrivanek michalskrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no point in enumerating individual files. The only other file that gets downloaded using the original documentation is a README.md. What's so harmful about that to justify this ugly list of things that may change in future and will require changing docs?

@emarcusRH
Copy link
Contributor Author

emarcusRH commented Apr 7, 2022

I see no point in enumerating individual files. The only other file that gets downloaded using the original documentation is a README.md. What's so harmful about that to justify this ugly list of things that may change in future and will require changing docs? >>

I think it's helpful to see the URLs you are accessing - I followed the example in the OpenStack install section -
openstack installation download playbooks

Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@EricPonvelle EricPonvelle added this to the Next Release milestone Apr 13, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
@EricPonvelle EricPonvelle merged commit 301d2aa into openshift:main Apr 13, 2022
@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #44723

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh modified the milestones: Next Release, OCP 4.11 GA Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants