-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ocprhv-417 updates to URLs for ansible playbook download #44233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for osdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
michalskrivanek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no point in enumerating individual files. The only other file that gets downloaded using the original documentation is a README.md. What's so harmful about that to justify this ugly list of things that may change in future and will require changing docs?
I think it's helpful to see the URLs you are accessing - I followed the example in the OpenStack install section - |
EricPonvelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/cherrypick enterprise-4.11 |
|
@EricPonvelle: new pull request created: #44723 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Target - enterprise-4.11
https://issues.redhat.com/browse/OCPRHV-417
update GitHub resource URL and command for downloading installer Ansible playbooks
redoing to correct typos in the URLs and insert the correct attribute for the release version
Preview: https://deploy-preview-44233--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_rhv/installing-rhv-user-infra.html#installation-rhv-downloading-ansible-playbooks_installing-rhv-user-infra