Skip to content

Conversation

@HarshCasper
Copy link
Contributor

@HarshCasper HarshCasper commented Mar 6, 2022

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2022
@netlify
Copy link

netlify bot commented Mar 6, 2022

Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarshCasper Left a few suggestions, PTAL. Thanks!

@HarshCasper HarshCasper force-pushed the RHDEVDOCS-3623 branch 2 times, most recently from d76f061 to 9fd58c2 Compare March 7, 2022 11:18
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Srivaralakshmi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2022

New changes are detected. LGTM label has been removed.

@HarshCasper HarshCasper force-pushed the RHDEVDOCS-3623 branch 2 times, most recently from a41a4ea to 2865359 Compare March 7, 2022 14:53
@Preeticp Preeticp added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.10 labels Mar 7, 2022
@Preeticp Preeticp merged commit 0fd0986 into openshift:main Mar 7, 2022
@Preeticp
Copy link
Contributor

Preeticp commented Mar 7, 2022

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@Preeticp: new pull request created: #42892

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants