Skip to content

Conversation

@emarcusRH
Copy link
Contributor

@emarcusRH emarcusRH commented Oct 12, 2021

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2021
@netlify
Copy link

netlify bot commented Oct 12, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 925aa8e

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6165a31382b5df000827ae76

😎 Browse the preview: https://deploy-preview-37384--osdocs.netlify.app

@emarcusRH emarcusRH closed this Oct 12, 2021
@openshift-ci openshift-ci bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2021
@emarcusRH emarcusRH reopened this Oct 12, 2021
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2021
@Gal-Zaidman
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2021
@emarcusRH
Copy link
Contributor Author

Michael Burman 2021-10-19 06:59:10 UTC

(In reply to Eli Marcus from comment #3)

received ack/lgtm from Gal Z
needs QE ack
and then final peer review

ack from QE, thanks

Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small note. Please add the enterprise branch you need this merged to in the first comment of your PR.

Otherwise, LGTM.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@mburke5678: new pull request created: #37746

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@mburke5678: new pull request created: #37747

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 branch/enterprise-4.10 lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants