-
Notifications
You must be signed in to change notification settings - Fork 1.8k
BZ#1962763 conditionalize machine-pool ref in parameter description for RHV only #37384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 925aa8e 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6165a31382b5df000827ae76 😎 Browse the preview: https://deploy-preview-37384--osdocs.netlify.app |
|
/lgtm |
|
Michael Burman 2021-10-19 06:59:10 UTC (In reply to Eli Marcus from comment #3)
ack from QE, thanks |
michaelryanpeter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small note. Please add the enterprise branch you need this merged to in the first comment of your PR.
Otherwise, LGTM.
|
/cherrypick enterprise-4.9 |
|
@mburke5678: new pull request created: #37746 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.10 |
|
@mburke5678: new pull request created: #37747 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=1962763
enterprise-4.9
enterprise 4.10
can also be ported to any recent versions that are actively used by customers.
Previews:
AWS - no mention of Machine-pools table -
https://deploy-preview-37384--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-customizations.html#installation-configuration-parameters-optional_installing-aws-customizations
RHV - mention of "Additional RHV parameters for machine pools" table.
https://deploy-preview-37384--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_rhv/installing-rhv-customizations.html#installation-configuration-parameters-optional_installing-rhv-customizations