Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-3018 Document: [Logging 5.1]EO shouldn't try to upgrade ES … #34430

Merged
merged 1 commit into from
Jul 21, 2021
Merged

RHDEVDOCS-3018 Document: [Logging 5.1]EO shouldn't try to upgrade ES … #34430

merged 1 commit into from
Jul 21, 2021

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jul 8, 2021 •
edited
Loading

…cluster after adding/removing storage.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2021
@netlify
Copy link

netlify bot commented Jul 8, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 8cb7f81

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60ec6a08a9627f000862fd44

😎 Browse the preview: https://deploy-preview-34430--osdocs.netlify.app/openshift-enterprise/latest/logging/troubleshooting/cluster-logging-log-store-status

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 9, 2021
Srivaralakshmi
Srivaralakshmi reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfedh As always, great work! Enjoyed reviewing. Left a few suggestions. Otherwise, LGTM. PTAL. Thanks!

Red-GV
Red-GV approved these changes Jul 12, 2021
View reviewed changes
Copy link

@Red-GV Red-GV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor thing:

the OpenShift Elasticsearch Operator created a persistent volume claim (PVC) even though it did not create a persistent volume (PV).

To me, it reads a tad awkwardly, but I'm not entirely sure how exactly to word it. It might be fine as is.

@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 12, 2021

Thanks, @Red-GV. I've updated the phrase.

@kabirbhartiRH
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@Preeticp Preeticp added branch/enterprise-4.7 branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR labels Jul 21, 2021
@Preeticp Preeticp merged commit 0816f60 into openshift:master Jul 21, 2021
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.7

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 21, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #34765

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 21, 2021
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #34766

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Srivaralakshmi Srivaralakshmi Srivaralakshmi left review comments

@Red-GV Red-GV Red-GV approved these changes

Assignees

@kabirbhartiRH kabirbhartiRH

Labels
branch/enterprise-4.7 branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rolfedh @kabirbhartiRH @Preeticp @openshift-cherrypick-robot @Srivaralakshmi @Red-GV