Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ#1946889: Add Sample YAML file for RHV #33543

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

dcdacosta
Copy link
Contributor

@dcdacosta dcdacosta commented Jun 16, 2021

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2021
@netlify
Copy link

netlify bot commented Jun 16, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: eb20d22

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60ca7293b5afb50007d52fbb

😎 Browse the preview: https://deploy-preview-33543--osdocs.netlify.app

@vikram-redhat vikram-redhat changed the title BZ#1946889 - Add Sample YAML file for RHV BZ#1946889: Add Sample YAML file for RHV Jun 17, 2021
@Gal-Zaidman
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@mburke5678
Copy link
Contributor

@dcdacosta LGTM. Will you get a QE review? This is for 4.8 only? The BZ is against the 4.7 docs.

@dcdacosta
Copy link
Contributor Author

@mburke5678 The BZ says 4.8 for the version. I can have the change also placed in the 4.7 stream if needed? This yaml file has been in the doc in a different location for some time now, so I'm not sure it needs a QE review? I'm still new to this process, so let me know if I'm mistaken.

@mburke5678
Copy link
Contributor

Cherrypick to 4.7 and 4.8 per Slack conversation with @dcdacosta. QE verified the BZ.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@mburke5678: new pull request created: #33752

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@mburke5678: new pull request created: #33753

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.7 branch/enterprise-4.8 lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants