Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPA-3100: Convert kmod instructions from filetranspiler to Butane #33305

Merged
merged 1 commit into from
Jun 16, 2021
Merged

GRPA-3100: Convert kmod instructions from filetranspiler to Butane #33305

merged 1 commit into from
Jun 16, 2021

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Jun 10, 2021 •
edited
Loading

The current RHCOS systemd can now enable instantiated services via Ignition.

The embedded SSH key was apparently inherited from the instructions here and shouldn't be needed on OCP. Drop it.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 10, 2021
@netlify
Copy link

netlify bot commented Jun 10, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: bf2157b

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60ca73bc5b067f0008509b50

😎 Browse the preview: https://deploy-preview-33305--osdocs.netlify.app/openshift-enterprise/latest/installing/install_config/installing-customizing

@bgilbert
Copy link
Contributor Author

cc @bobfuru @dustymabe

@bgilbert
Copy link
Contributor Author

This requires Butane 0.12.1 (which we're in the process of shipping to mirror.openshift.com) because of RHBZ 1970218.

@bgilbert
Copy link
Contributor Author

Butane 0.12.1 is posted on the mirror now.

@bobfuru bobfuru self-requested a review June 16, 2021 18:28
bobfuru
bobfuru reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bgilbert!
Couple of minor nits if you'd like to update but otherwise LGTM. Let me know when you're ready for this to merge.

@bobfuru bobfuru added branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR labels Jun 16, 2021
@bobfuru bobfuru added this to the Future Release milestone Jun 16, 2021
@bgilbert
Copy link
Contributor Author

Ready to merge if #33305 (comment) doesn't need addressing.

@bgilbert
GRPA-3100: Convert kmod instructions from filetranspiler to Butane
bf2157b 
The current RHCOS systemd can now enable instantiated services via
Ignition.

The embedded SSH key was apparently inherited from the instructions in
https://github.com/kmods-via-containers/kmods-via-containers#testing-it-out-on-an-ostree-based-host-provisioned-via-ignition
and shouldn't be needed on OCP.  Drop it.
@bgilbert
Copy link
Contributor Author

Updated for #33305 (comment) and ready to merge.

@bobfuru bobfuru merged commit fa1a9fa into openshift:master Jun 16, 2021
@bgilbert bgilbert deleted the butane-kmod branch June 16, 2021 22:00
@bobfuru
Copy link
Contributor

bobfuru commented Jun 16, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 16, 2021
Merged
@openshift-cherrypick-robot
Copy link

@bobfuru: new pull request created: #33547

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe left review comments

@bobfuru bobfuru bobfuru left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.8 GA
Development

Successfully merging this pull request may close these issues.
5 participants
@bgilbert @bobfuru @openshift-cherrypick-robot @dustymabe @vikram-redhat