Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS-3052: Fix how buildArgs is capitalized #33192

Merged
merged 1 commit into from
Jun 8, 2021
Merged

RHDEVDOCS-3052: Fix how buildArgs is capitalized #33192

merged 1 commit into from
Jun 8, 2021

Conversation

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2021
@netlify
Copy link

netlify bot commented Jun 7, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 2324984

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60be7ee64c09b80008a697f4

😎 Browse the preview: https://deploy-preview-33192--osdocs.netlify.app

@vikram-redhat vikram-redhat changed the title RHDEVDOCS-3052 Fix how buildArgs is capitalized RHDEVDOCS-3052: Fix how buildArgs is capitalized Jun 8, 2021
@gabemontero
Copy link
Contributor

sure making if more "yaml friendly" vs. golang compliant makes sense to me

LGTM

@adambkaplan FYI

@Preeticp
Copy link
Contributor

Preeticp commented Jun 8, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@Preeticp Preeticp added branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR labels Jun 8, 2021
@Preeticp Preeticp merged commit 9fa99dc into openshift:master Jun 8, 2021
@Preeticp
Copy link
Contributor

Preeticp commented Jun 8, 2021

/cherrypick enterprise-4.5

@Preeticp
Copy link
Contributor

Preeticp commented Jun 8, 2021

/cherrypick enterprise-4.6

@Preeticp
Copy link
Contributor

Preeticp commented Jun 8, 2021

/cherrypick enterprise-4.7

@Preeticp
Copy link
Contributor

Preeticp commented Jun 8, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@Preeticp: new pull request created: #33204

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@Preeticp: new pull request created: #33205

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@Preeticp: new pull request created: #33206

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@Preeticp: new pull request created: #33207

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants