Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For 4.8 CSI/in-tree topics, add migration notice #33190

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Jun 7, 2021

Here's the notice text I'm proposing for 4.8 for CSI driver topics that have in-tree plugins, as well as in-tree plugin topics that have CSI drivers. The build fails for this PR due to the xref to the auto migration topic, which is on a separate PR #31774.

Preview: https://deploy-preview-33190--osdocs.netlify.app/openshift-enterprise/latest/storage/understanding-persistent-storage.html
The notice text has been add to the following topics (CSIs and in-tree):

PTAL @jsafrane, @gnufied, @huffmanca, @bertinatto, @tsmetana, @jhou1 @duanwei33

@netlify
Copy link

netlify bot commented Jun 7, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 0ac3b23

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60c9f66e0c88bd0009383b87

😎 Browse the preview: https://deploy-preview-33190--osdocs.netlify.app

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 7, 2021
@jsafrane
Copy link
Contributor

jsafrane commented Jun 8, 2021

looks good to me, WDYT @gnufied?

@duanwei33
Copy link

lgtm from QE side.

@adellape adellape self-requested a review June 15, 2021 14:36
@adellape adellape added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 15, 2021
@adellape adellape added this to the Future Release milestone Jun 15, 2021
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment inline.

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.8 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 15, 2021
@mburke5678 mburke5678 merged commit cc9fd11 into openshift:master Jun 16, 2021
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@mburke5678: new pull request created: #33495

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants