Add SR-IOV doc for shift-on-stack #28418

zshi-redhat · 2021-01-07T04:57:52Z

No description provided.

zshi-redhat · 2021-01-07T05:01:03Z

/cc @jboxman ptal, the sriov doc for https://issues.redhat.com/browse/SDN-1170

/cc @atyronesmith

jboxman · 2021-01-08T02:27:18Z

@zshi-redhat looks like after 2 years I learned how to push to someone else's PR;

Can you look at the changes and let me know what you think?

Thanks!

zshi-redhat · 2021-01-08T02:31:54Z

modules/nw-sriov-networknodepolicy-object.adoc

    pfNames: ["<pf_name>", ...] <11>
    rootDevices: ["<pci_bus_id>", "..."] <12>
-	netFilter: "<filter_string>" <13>
+  netFilter: "<filter_string>" <13>


Looks like the indent is not perfect yet, we need to keep it the same as other selectors like rootDevices.

Indent still doesn't look correct?

zshi-redhat · 2021-01-08T02:33:54Z

modules/nw-sriov-networknodepolicy-object.adoc

-====
-`xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx` is the `network_id` from `/var/config/openstack/latest/network_data.json` metadata file.
-====
+<13> Optional: The platform specific filter string. The only supported platform is {rh-openstack-first}. Acceptable values are of the following format: `openstack/NetworkID:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx`. Replace `xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx` with the value from the `/var/config/openstack/latest/network_data.json` metadata file.


Nice change!

In addition, the administrator should also know the OpenStack Network UUID apriori as part of network planning. The OpenStack networks are created to glue together the different VNF/CNF components in the system and have been architected to carry the necessary information.

zshi-redhat · 2021-01-08T02:34:45Z

modules/nw-sriov-networknodepolicy-object.adoc

 ----

-The following example describes the configuration for a SR-IOV device in OpenStack Virtual Machine:
+The following example describes the configuration for an SR-IOV device in a {rh-openstack} virtual machine:


I noticed the platform is using {rh-openstack-first} in <13>, but this one is {rh-openstack}, is there any difference?

zshi-redhat · 2021-01-08T02:37:17Z

@zshi-redhat looks like after 2 years I learned how to push to someone else's PR;

You got to share the tips :-)

atyronesmith

Maybe a few tweaks on line 64, but not really necessary.

atyronesmith · 2021-01-08T13:46:45Z

modules/nw-sriov-networknodepolicy-object.adoc

-====
-`xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx` is the `network_id` from `/var/config/openstack/latest/network_data.json` metadata file.
-====
+<13> Optional: The platform specific filter string. The only supported platform is {rh-openstack-first}. Acceptable values are of the following format: `openstack/NetworkID:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx`. Replace `xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx` with the value from the `/var/config/openstack/latest/network_data.json` metadata file.


In addition, the administrator should also know the OpenStack Network UUID apriori as part of network planning. The OpenStack networks are created to glue together the different VNF/CNF components in the system and have been architected to carry the necessary information.

atyronesmith · 2021-01-08T13:47:59Z

modules/nw-sriov-networknodepolicy-object.adoc

    pfNames: ["<pf_name>", ...] <11>
    rootDevices: ["<pci_bus_id>", "..."] <12>
-	netFilter: "<filter_string>" <13>
+  netFilter: "<filter_string>" <13>


Indent still doesn't look correct?

atyronesmith · 2021-01-08T13:50:05Z

modules/nw-sriov-networknodepolicy-object.adoc

+    feature.node.kubernetes.io/network-sriov.capable: "true"
+  numVfs: 1 <1>
+  nicSelector:
+    vendor: "15b3"


The 'vendor' and 'deviceID' fields are mostly superfluous as there real match is to the UUID.

@atyronesmith I don't have environment to test, if we remove vendor/device IDs from policy, will it expose virtio or other non-sriov devices as k8s resource when the given network ID matches ?

My environment is down now as well.... However, if I remember correctly (and I look at https://github.com/openshift/sriov-network-operator/blob/f6aba07546d2c85b319bf3bfeb9deb45a2f007f5/api/v1/helper.go#L429)

A non-zero netFilter will only match that specific netfiler.

@atyronesmith , Jason asked me to do light wordsmithing on this PR and then get it merged. Regarding these two comments about the nicSelector:

Should netFilter be aligned with rootDevices? (I'm guessing yes if the same receiver function can handle both in the helper.go file, but I'm using my imagination.)

The 'vendor' and 'deviceID' fields are mostly superfluous as there real match is to the UUID.

Do you want the doc to suggest using netFilter because it is the most specific? Depending on your answer to this question and if you indicate that netFilter is subordinate to nicSelector, then netFilter deserves some mention in the callout for #8, nicSelector.

Hi @mikemckiernan, netFilter should be used as it is the most specific. RootDevices does not need to be used as netFilter is specific. NetFilter is subordinate to nicSelector and is at the same level as rootDevices, vendor, devicdeID, etc...

jboxman · 2021-01-11T21:07:07Z

@zshi-redhat, I used:

$ brew install gh
$ gh pr checkout 28418
# make changes to PR
$ git push

The gh command adds the correct upstream in the .git/config, so git push is enough.

jboxman · 2021-01-27T19:04:01Z

@zshi-redhat, I wonder if this file also needs to be updated? modules/nw-sriov-configuring-device.adoc

zshi-redhat · 2021-01-28T02:42:48Z

@zshi-redhat, I wonder if this file also needs to be updated? modules/nw-sriov-configuring-device.adoc

@jboxman thanks for the question, do you mean updating the virt-sriov section (for CNV product)?
If yes, the answer is no, reason being OCP on OSP is different from CNV in terms of using sriov-operator netFilter selector.
If CNV would run on OCP on OSP, then there will be nested VMs (CNV VM in OCP Pod in OSP VM), I didn't hear such request.

jboxman · 2021-02-03T01:35:00Z

Going to close this PR as superseded.

Add SR-IOV doc for shift-on-stack

1b271d2

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 7, 2021

openshift-ci-robot requested a review from atyronesmith January 7, 2021 05:01

jboxman self-assigned this Jan 7, 2021

Apply edits

b44901c

zshi-redhat commented Jan 8, 2021

View reviewed changes

atyronesmith approved these changes Jan 8, 2021

View reviewed changes

jboxman mentioned this pull request Jan 11, 2021

Add release note entry for using VFs in OCP on OSP #28499

Closed

mikemckiernan mentioned this pull request Feb 1, 2021

sr-iov related to RHOSP (SDN-1170) #29024

Merged

jboxman closed this Feb 3, 2021

Add SR-IOV doc for shift-on-stack #28418

Add SR-IOV doc for shift-on-stack #28418

Uh oh!

Conversation

zshi-redhat commented Jan 7, 2021

Uh oh!

zshi-redhat commented Jan 7, 2021

Uh oh!

jboxman commented Jan 8, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zshi-redhat commented Jan 8, 2021

Uh oh!

atyronesmith left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikemckiernan Feb 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jboxman commented Jan 11, 2021

Uh oh!

jboxman commented Jan 27, 2021

Uh oh!

zshi-redhat commented Jan 28, 2021

Uh oh!

jboxman commented Feb 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mikemckiernan Feb 1, 2021 •

edited

Loading