Skip to content

Revoke "RHOSP" initialism treatment #17388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

Revoke "RHOSP" initialism treatment #17388

merged 1 commit into from
Oct 16, 2019

Conversation

@maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Oct 16, 2019

4.2+

Context:

From the OSP DPM today:

We had a larger conversation around RHOSP this morning, with overwhelming support for "a RHOSP...".

I'll send a note to the writer team to ensure we are consistent when we write RHOSP. We do use the full name a lot...

@bergerhoffer Would you like to take this, since you're pretty familiar with the issue at this point? :)

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2019
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 16, 2019

@bobfuru Actually, you have the background on this, too, if you want it.

@bergerhoffer bergerhoffer self-requested a review October 16, 2019 20:10
@bergerhoffer bergerhoffer added branch/enterprise-4.2 branch/enterprise-4.3 peer-review-done Signifies that the peer review team has reviewed this PR labels Oct 16, 2019
bergerhoffer
bergerhoffer reviewed Oct 16, 2019
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @maxwelldb! As much as I'd prefer "an", I'm fine with honoring the team's decision. Thanks, this LGTM!

@bergerhoffer bergerhoffer merged commit df278e8 into openshift:master Oct 16, 2019
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Oct 16, 2019

/cherrypick enterprise-4.2

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Oct 16, 2019

/cherrypick enterprise-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 16, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 16, 2019

@bergerhoffer: new pull request created: #17405

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 16, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 16, 2019

@bergerhoffer: new pull request created: #17406

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 16, 2019

Thanks!

@maxwelldb maxwelldb deleted the rhosp-rename-redux branch October 16, 2019 20:35
@maxwelldb maxwelldb mentioned this pull request Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.2 branch/enterprise-4.3 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maxwelldb @bergerhoffer @openshift-cherrypick-robot @openshift-ci-robot