Skip to content

Conversation

@kalexand-rh
Copy link
Contributor

@jianlinliu, I've made some changes based on your comments on
#16678 and
#16696

This PR does not include the changes for https://bugzilla.redhat.com/show_bug.cgi?id=1743483, which I'm going to open separately.

Please let me know what else I need to change.

@kalexand-rh kalexand-rh added this to the Future Release milestone Oct 4, 2019
@kalexand-rh kalexand-rh self-assigned this Oct 4, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 4, 2019
@openshift-docs-preview-bot

The preview will be available shortly at:

@jianlinliu
Copy link

LGTM

@kalexand-rh
Copy link
Contributor Author

Thank you! Merging.

@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-4.2

@openshift-cherrypick-robot

@kalexand-rh: once the present PR merges, I will cherry-pick it on top of enterprise-4.2 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh merged commit 57203a9 into openshift:master Oct 8, 2019
@kalexand-rh kalexand-rh deleted the 627-followup branch October 8, 2019 14:18
@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #17100

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.2 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants