Skip to content

osdocs-690 entitlement updates #16985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

osdocs-690 entitlement updates #16985

merged 1 commit into from
Oct 16, 2019

Conversation

@kalexand-rh
Copy link
Contributor

@kalexand-rh kalexand-rh commented Oct 1, 2019 •
edited
Loading

@kalexand-rh kalexand-rh added this to the Future Release milestone Oct 1, 2019
@kalexand-rh kalexand-rh self-assigned this Oct 1, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 1, 2019
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Oct 1, 2019

The preview will be available shortly at:

wking
wking reviewed Oct 2, 2019
View reviewed changes
wking
wking reviewed Oct 2, 2019
View reviewed changes
wking
wking reviewed Oct 2, 2019
View reviewed changes
modules/cluster-entitlements.adoc Outdated
Copy link
Member

@wking wking Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems orthogonal to entitlements?

Copy link
Contributor Author

@kalexand-rh kalexand-rh Oct 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The topic's about internet access and entitlements.

wking
wking reviewed Oct 2, 2019
View reviewed changes
wking
wking reviewed Oct 2, 2019
View reviewed changes
wking
wking reviewed Oct 2, 2019
View reviewed changes
@kalexand-rh kalexand-rh mentioned this pull request Oct 4, 2019
Merged
reestr
reestr reviewed Oct 7, 2019
View reviewed changes
reestr
reestr reviewed Oct 7, 2019
View reviewed changes
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2019
@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Oct 10, 2019

@jianlinliu, will you PTAL or suggest a different reviewer?

@jianlinliu
Copy link

jianlinliu commented Oct 11, 2019

@juzhao Is this in your test scope? If yes, pls help review.

@juzhao
Copy link

juzhao commented Oct 11, 2019 •
edited
Loading

@juzhao Is this in your test scope? If yes, pls help review.
@jianlinliu
Only 2 docs have "telemetry" keyword:
modules/cluster-entitlements.adoc
modules/installation-overview.adoc

For the paragraphs of the above 2 docs which have "telemetry" keyword is our scope. Reviewed, they are LGTM.
For the paragraphs of the above 2 docs which don't have "telemetry" keyword and the other 3 docs is not our scope.

@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Oct 14, 2019

@openshift/team-documentation, will you PTAL?

@kalexand-rh kalexand-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 14, 2019
@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Oct 14, 2019

@wmengRH, will you PTAL at the change to modules/rhel-compute-overview.adoc?

@bergerhoffer bergerhoffer self-requested a review October 14, 2019 15:36
bergerhoffer
bergerhoffer reviewed Oct 14, 2019
View reviewed changes
@bergerhoffer bergerhoffer removed the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 14, 2019
@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 14, 2019
@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Oct 15, 2019

@xltian, who should finish this review?

@maxwelldb maxwelldb mentioned this pull request Oct 15, 2019
Merged
@jianlinliu
Copy link

jianlinliu commented Oct 16, 2019 •
edited
Loading

@gpei could you help review the change to modules/rhel-compute-overview.adoc ?

@jianlinliu
Copy link

jianlinliu commented Oct 16, 2019

The change to modules/installation-overview.adoc looks good to me.

@gpei
Copy link

gpei commented Oct 16, 2019

Most of the changes to modules/rhel-compute-overview.adoc lgtm, except for the following sentence:
Although you must entitle them for their use of RHEL, RHEL compute machines are exempt from the {product-title} entitlement calculations.
I don't know what does this mean, maybe it's not a functional feature covered by OpenShift QE.

@vikram-redhat
Copy link
Contributor

vikram-redhat commented Oct 16, 2019

Thanks @gpei . In this case, I will hold off on merging this and this can come as an async update tomorrow.

@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Oct 16, 2019

@gpei is right, and Tim Rees approved that line separately in Slack. I'm going to go ahead and merge. Thank you all for reviewing the change!

@kalexand-rh kalexand-rh merged commit 40ee7f0 into openshift:master Oct 16, 2019
@kalexand-rh kalexand-rh deleted the osdocs690 branch October 16, 2019 12:33
@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Oct 16, 2019

/cherrypick enterprise-4.2

@kalexand-rh
Copy link
Contributor Author

kalexand-rh commented Oct 16, 2019

/cherrypick enterprise-4.3

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 16, 2019

@kalexand-rh: new pull request created: #17367

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 16, 2019
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 16, 2019

@kalexand-rh: new pull request created: #17368

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@maxwelldb maxwelldb maxwelldb left review comments

+2 more reviewers

@wking wking wking left review comments

@reestr reestr reestr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kalexand-rh kalexand-rh

Labels

branch/enterprise-4.2 branch/enterprise-4.3 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.