Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoadBalancer details to OSD docs #13435

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

wgordon17
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 24, 2019
@wgordon17
Copy link
Contributor Author

@wgordon17
Copy link
Contributor Author

@wgordon17
Copy link
Contributor Author

@spurtell Can I get a content review?

@blrm
Copy link

blrm commented Jan 25, 2019

@wgordon17 👍 lgtm

@wgordon17 wgordon17 changed the title Add LoadBalancer details to OSD docs (WIP) Add LoadBalancer details to OSD docs Jan 25, 2019
@wgordon17
Copy link
Contributor Author

Hey @ahardin-rh this is pending a new subscription offering, so can't merge this yet. But once the SKU goes live, this will be ready to go 👍

@ahardin-rh ahardin-rh self-assigned this Jan 25, 2019
@ahardin-rh ahardin-rh added this to the Next Release milestone Jan 25, 2019
[[expose-tcp-services]]
== Expose TCP Services

{product-title} xref:../architecture/networking/routes.adoc[routes] expose applications by proxying traffic through HTTP/HTTPS(SNI)/TLS(SNI)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include the section ID at the top of the page.

xref:../architecture/networking/routes.adoc#architecture-core-concepts-routes[routes]

xref:../architecture/core_concepts/pods_and_services.adoc#architecture-core-concepts-pods-and-services[pods and services]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems very odd...is it just because I'm xrefing the adoc version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wgordon17 Yeah, for some reason the missing section IDs cause the builds to go wonky.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird 🤷‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know 👎


[NOTE]
====
LoadBalancer services require an additional purchase. Reach out to your sales team if you're interested in using LoadBalancer services for your {product-title} cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Reach out to your sales team if you're/Contact your sales team if you are


=== Check your LoadBalancer Quota

By purchasing LoadBalancer services, you're provided with a quota of LoadBalancers available for your {product-title} cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/you're/you are


=== Use your TCP Service

Once you've created your LoadBalancer service, you can access your service by using the URL provided to you by {product-title}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once your LoadBalancer service is created, you can


Once you've created your LoadBalancer service, you can access your service by using the URL provided to you by {product-title}.
The `LoadBalancer Ingress` value is a URL unique to your service that remains static as long as the service is not deleted. You
may create a CNAME DNS record for this URL if you prefer to use a custom domain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you prefer to use a custom domain, you can create a CNAME DNS record for this URL.

@wgordon17
Copy link
Contributor Author

Thanks for the review @ahardin-rh, all fixed up 👍

@ahardin-rh
Copy link
Contributor

@wgordon17 Do we have a target date for when this should merge?

@wgordon17
Copy link
Contributor Author

@ahardin-rh Ready for this to go live 👍

@ahardin-rh ahardin-rh merged commit dc61c47 into openshift:master Feb 6, 2019
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-3.11

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #13557

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wgordon17 wgordon17 deleted the add-lb-osd-docs branch February 14, 2019 20:00
@wgordon17 wgordon17 restored the add-lb-osd-docs branch May 1, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.11 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants