-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LoadBalancer details to OSD docs #13435
Conversation
@spurtell Can I get a content review? |
@wgordon17 👍 lgtm |
Hey @ahardin-rh this is pending a new subscription offering, so can't merge this yet. But once the SKU goes live, this will be ready to go 👍 |
[[expose-tcp-services]] | ||
== Expose TCP Services | ||
|
||
{product-title} xref:../architecture/networking/routes.adoc[routes] expose applications by proxying traffic through HTTP/HTTPS(SNI)/TLS(SNI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to include the section ID at the top of the page.
xref:../architecture/networking/routes.adoc#architecture-core-concepts-routes[routes]
xref:../architecture/core_concepts/pods_and_services.adoc#architecture-core-concepts-pods-and-services[pods and services]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems very odd...is it just because I'm xref
ing the adoc
version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wgordon17 Yeah, for some reason the missing section IDs cause the builds to go wonky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know 👎
|
||
[NOTE] | ||
==== | ||
LoadBalancer services require an additional purchase. Reach out to your sales team if you're interested in using LoadBalancer services for your {product-title} cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Reach out to your sales team if you're/Contact your sales team if you are
|
||
=== Check your LoadBalancer Quota | ||
|
||
By purchasing LoadBalancer services, you're provided with a quota of LoadBalancers available for your {product-title} cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/you're/you are
|
||
=== Use your TCP Service | ||
|
||
Once you've created your LoadBalancer service, you can access your service by using the URL provided to you by {product-title}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once your LoadBalancer service is created, you can
|
||
Once you've created your LoadBalancer service, you can access your service by using the URL provided to you by {product-title}. | ||
The `LoadBalancer Ingress` value is a URL unique to your service that remains static as long as the service is not deleted. You | ||
may create a CNAME DNS record for this URL if you prefer to use a custom domain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you prefer to use a custom domain, you can create a CNAME DNS record for this URL.
f351b18
to
06ddfb0
Compare
06ddfb0
to
4d4377c
Compare
Thanks for the review @ahardin-rh, all fixed up 👍 |
@wgordon17 Do we have a target date for when this should merge? |
@ahardin-rh Ready for this to go live 👍 |
/cherrypick enterprise-3.11 |
@ahardin-rh: new pull request created: #13557 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.