Skip to content

OSDOCS-16948#CQA work Stor4 - vSphere CSI driver - #114546

Merged
lpettyjo merged 1 commit into
openshift:mainfrom
lpettyjo:OSDOCS-16948-csi-vsphere-driver
Jul 29, 2026
Merged

OSDOCS-16948#CQA work Stor4 - vSphere CSI driver#114546
lpettyjo merged 1 commit into
openshift:mainfrom
lpettyjo:OSDOCS-16948-csi-vsphere-driver

Conversation

@lpettyjo

@lpettyjo lpettyjo commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 2, 2026
@lpettyjo lpettyjo added this to the Continuous Release milestone Jul 2, 2026
Comment thread storage/container_storage_interface/persistent-storage-csi-vsphere.adoc Outdated
@lpettyjo
lpettyjo force-pushed the OSDOCS-16948-csi-vsphere-driver branch from d6f3132 to 3b21878 Compare July 10, 2026 14:46
@lpettyjo lpettyjo added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 10, 2026
@stevsmit stevsmit added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jul 16, 2026

@stevsmit stevsmit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quit reviewing this in modules/persistent-storage-csi-vsphere-overview.adoc because there's just a lot of errors that appear to be done by AI, such as lack of IDs, sections titled "Overview" etc, which aren't compliant with either IBMSG or RHSSG or OSDOCS guidelines. This is a common problem across multiple PRs.

AI is an OK tool, but the outputs have to be validated and made compliant with our rules.

Comment thread modules/persistent-storage-csi-vsphere-change-max-snapshot.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-encryption-datastore-url.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-encryption-tag-based.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-encryption.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-overview.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-procedure.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-overview.adoc Outdated
@lpettyjo lpettyjo removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 20, 2026
@lpettyjo
lpettyjo force-pushed the OSDOCS-16948-csi-vsphere-driver branch 3 times, most recently from 8cea995 to de8932b Compare July 21, 2026 01:38
@lpettyjo lpettyjo removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jul 21, 2026
@lpettyjo

lpettyjo commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

@stevsmit PTAL. Addressed comments. FYI, content was not created by AI.

@lpettyjo lpettyjo added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 21, 2026
@cbippley

Copy link
Copy Markdown
Contributor

/label merge-review-in-progress

@cbippley

Copy link
Copy Markdown
Contributor

/remove-label merge-review-needed

@openshift-ci openshift-ci Bot added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 23, 2026
@cbippley

cbippley commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Visual Review Guide — OSDOCS-16948

Summary: CQA rework of 24 vSphere CSI driver docs. Extracts overview and encryption content into standalone modules, adds abstracts, converts callouts to inline descriptions, and restructures the assembly.

Quick Navigation

Base URL: https://114546--ocpdocs-pr.netlify.app/openshift-enterprise/latest

Main Assembly (start here)

Section Preview Link
Overview (new module) persistent-storage-csi-vsphere.html#overview
Limitations #limitations
Storage policy #stor-policy
ReadWriteMany #rwx
Driver requirements #csi-driver-reqs
Remove third-party driver #install-issues

Encryption

Section Preview Link
Encryption overview (new module) #encryption
Datastore URL method #encryption-datastore-url
Tag-based placement #encryption-tag-based

Topology-Aware Provisioning

Section Preview Link
Topology overview #top-aware-overview
During installation #top-aware-during-install
Post-installation #top-aware-post-install
Infrastructure topology #top-aware-infra-top
Verify results #top-aware-results

Other Sections

Section Preview Link
Multi-vCenter overview #multi-vcenter-overview
Migrating CNS volumes #migrating-cns-vols
Disable/enable storage #disable-storage-overview
Bare-metal nodes #adding-bm-nodes
Increase max volumes #increase-max-vols

Install Requirement Pages (shared module)

Page Preview Link
IPI install reqs ipi-vsphere-installation-reqs.html#csi-driver-reqs
UPI install reqs upi-vsphere-installation-reqs.html#csi-driver-reqs

Review Checklist

  • Overview module: New standalone module — verify content renders correctly and abstracts display
  • Encryption section: New concept module extracted from assembly — check two sub-procedures (datastore URL, tag-based) still flow logically
  • Topology sections: Verify YAML examples render (callouts removed, inline descriptions added)
  • Install-issues module: Content type changed CONCEPT → PROCEDURE — verify structure
  • IPI/UPI install pages: Shared vmware-csi-driver-reqs module — confirm it renders in both contexts

@cbippley cbippley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed. Once they are fixed you can merge.

Comment thread modules/persistent-storage-csi-vsphere-overview.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-top-aware-overview.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-top-aware-overview.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-encryption-tag-based.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-encryption-datastore-url.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-adding-bm-nodes.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-overview.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-top-aware-infra-top.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-top-aware-infra-top.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-top-aware-results.adoc Outdated
@cbippley

Copy link
Copy Markdown
Contributor

/remove-label merge-review-in-progress

@openshift-ci openshift-ci Bot removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jul 23, 2026
@lpettyjo
lpettyjo force-pushed the OSDOCS-16948-csi-vsphere-driver branch 3 times, most recently from 6eb018f to 148b5f2 Compare July 28, 2026 17:29
Comment thread storage/container_storage_interface/persistent-storage-csi-vsphere.adoc Outdated
Comment thread storage/container_storage_interface/persistent-storage-csi-vsphere.adoc Outdated
@lpettyjo
lpettyjo force-pushed the OSDOCS-16948-csi-vsphere-driver branch 6 times, most recently from 28180ee to 86d6fc4 Compare July 29, 2026 00:46
@lpettyjo
lpettyjo force-pushed the OSDOCS-16948-csi-vsphere-driver branch from 86d6fc4 to e3f9141 Compare July 29, 2026 01:06
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lpettyjo
lpettyjo merged commit c2cec02 into openshift:main Jul 29, 2026
2 checks passed
@lpettyjo

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-5.0

@lpettyjo

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.22

@lpettyjo

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.21

@openshift-cherrypick-robot

Copy link
Copy Markdown

@lpettyjo: #114546 failed to apply on top of branch "enterprise-5.0":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details

In response to this:

/cherrypick enterprise-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@lpettyjo: new pull request created: #116774

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@lpettyjo: new pull request created: #116775

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants