OSDOCS-16948#CQA work Stor4 - vSphere CSI driver - #114546
Conversation
d6f3132 to
3b21878
Compare
stevsmit
left a comment
There was a problem hiding this comment.
I quit reviewing this in modules/persistent-storage-csi-vsphere-overview.adoc because there's just a lot of errors that appear to be done by AI, such as lack of IDs, sections titled "Overview" etc, which aren't compliant with either IBMSG or RHSSG or OSDOCS guidelines. This is a common problem across multiple PRs.
AI is an OK tool, but the outputs have to be validated and made compliant with our rules.
8cea995 to
de8932b
Compare
|
@stevsmit PTAL. Addressed comments. FYI, content was not created by AI. |
|
/label merge-review-in-progress |
|
/remove-label merge-review-needed |
Visual Review Guide — OSDOCS-16948Summary: CQA rework of 24 vSphere CSI driver docs. Extracts overview and encryption content into standalone modules, adds abstracts, converts callouts to inline descriptions, and restructures the assembly. Quick NavigationBase URL: Main Assembly (start here)
Encryption
Topology-Aware Provisioning
Other Sections
Install Requirement Pages (shared module)
Review Checklist
|
cbippley
left a comment
There was a problem hiding this comment.
Some changes needed. Once they are fixed you can merge.
|
/remove-label merge-review-in-progress |
6eb018f to
148b5f2
Compare
28180ee to
86d6fc4
Compare
86d6fc4 to
e3f9141
Compare
|
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-5.0 |
|
/cherrypick enterprise-4.22 |
|
/cherrypick enterprise-4.21 |
|
@lpettyjo: #114546 failed to apply on top of branch "enterprise-5.0": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lpettyjo: new pull request created: #116774 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lpettyjo: new pull request created: #116775 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.20+
Issue: https://redhat.atlassian.net/browse/OSDOCS-16948
Link to docs preview: https://114546--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-vsphere.html
QE review:
Additional information: