Skip to content

Conversation

@aspauldi
Copy link

@aspauldi aspauldi commented Jan 12, 2026

Version(s): 4.17+

Issue: CNV-76050

Link to docs preview: Configuring higher VM workload density (with Pod eviction conditions used by wasp-agent topic removed)

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2026
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 12, 2026

@aspauldi
Copy link
Author

/label-cnv

@aspauldi
Copy link
Author

Hi @IBezukh, Can you please review this doc PR for me? If it looks okay to you, I'll send it along to Denys. Thanks.

@dshchedr
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aspauldi Hi, thank you for the PR!
Can we take these changes to OCP 4.17 as well?
In addition I saw multiple place places in the "main" procedure file, can you please take a look at this reference PR for comparison?

@aspauldi
Copy link
Author

aspauldi commented Jan 14, 2026

@aspauldi Hi, thank you for the PR! Can we take these changes to OCP 4.17 as well? In addition I saw multiple place places in the "main" procedure file, can you please take a look at this reference PR for comparison?

Yes, I can add 4.17 to the list of doc versions to be updated.

I can also update the text shown in https://github.com/openshift/openshift-docs/pull/104593/files, but are you planning to update docs yourself in that PR? Sorry, I'm confused! :) I'm not sure what you mean by seeing multiple places.

@enp0s3
Copy link
Contributor

enp0s3 commented Jan 14, 2026

@aspauldi Hi, thank you for the PR! Can we take these changes to OCP 4.17 as well? In addition I saw multiple place places in the "main" procedure file, can you please take a look at this reference PR for comparison?

Yes, I can add 4.17 to the list of doc versions to be updated.

I can also update the text shown in https://github.com/openshift/openshift-docs/pull/104593/files, but are you planning to update docs yourself in that PR? Sorry, I'm confused! :) I'm not sure what you mean by seeing multiple places.

@aspauldi Nope I meant to create a draft PR for you as a reference because I am not familiar with how things work in the docs repo, so I wanted to express the general idea in the change via the draft PR.

@enp0s3
Copy link
Contributor

enp0s3 commented Jan 14, 2026

@aspauldi I will close the draft PR once it will become irrelevant

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
@aspauldi
Copy link
Author

Hi @enp0s3 and @dshchedr, can you please take another look at this PR? (There were changes after you reviewed it, Denys.) Thanks very much.

Copy link

@dshchedr dshchedr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aspauldi Thank you!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2026
@enp0s3
Copy link
Contributor

enp0s3 commented Jan 15, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 15, 2026

@aspauldi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sjhala-ccs sjhala-ccs added this to the Continuous Release milestone Jan 15, 2026
@sjhala-ccs sjhala-ccs merged commit 160c72e into openshift:main Jan 15, 2026
2 checks passed
@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.17

@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.18

@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.19

@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.20

@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.21

@openshift-cherrypick-robot

@sjhala-ccs: #104654 failed to apply on top of branch "enterprise-4.17":

Applying: CNV-76050
Using index info to reconstruct a base tree...
M	modules/virt-using-wasp-agent-to-configure-higher-vm-workload-density.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-using-wasp-agent-to-configure-higher-vm-workload-density.adoc
CONFLICT (content): Merge conflict in modules/virt-using-wasp-agent-to-configure-higher-vm-workload-density.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 CNV-76050

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sjhala-ccs: #104654 failed to apply on top of branch "enterprise-4.18":

Applying: CNV-76050
Using index info to reconstruct a base tree...
M	modules/virt-using-wasp-agent-to-configure-higher-vm-workload-density.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-using-wasp-agent-to-configure-higher-vm-workload-density.adoc
CONFLICT (content): Merge conflict in modules/virt-using-wasp-agent-to-configure-higher-vm-workload-density.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 CNV-76050

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sjhala-ccs: #104654 failed to apply on top of branch "enterprise-4.19":

Applying: CNV-76050
Using index info to reconstruct a base tree...
M	modules/virt-using-wasp-agent-to-configure-higher-vm-workload-density.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-using-wasp-agent-to-configure-higher-vm-workload-density.adoc
CONFLICT (content): Merge conflict in modules/virt-using-wasp-agent-to-configure-higher-vm-workload-density.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 CNV-76050

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sjhala-ccs: new pull request created: #104866

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sjhala-ccs: new pull request created: #104867

Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 CNV Label for all CNV PRs lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants