-
Notifications
You must be signed in to change notification settings - Fork 1.9k
CNV#76050: [docs] wasp-agent: remove "Pod eviction conditions" paragraph #104654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Thu Jan 15 18:22:30 - Prow CI generated the docs preview: |
|
/label-cnv |
|
Hi @IBezukh, Can you please review this doc PR for me? If it looks okay to you, I'll send it along to Denys. Thanks. |
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can add 4.17 to the list of doc versions to be updated. I can also update the text shown in https://github.com/openshift/openshift-docs/pull/104593/files, but are you planning to update docs yourself in that PR? Sorry, I'm confused! :) I'm not sure what you mean by seeing multiple places. |
@aspauldi Nope I meant to create a draft PR for you as a reference because I am not familiar with how things work in the docs repo, so I wanted to express the general idea in the change via the draft PR. |
|
@aspauldi I will close the draft PR once it will become irrelevant |
dshchedr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
enp0s3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aspauldi Thank you!
|
/lgtm |
|
@aspauldi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
sjhala-ccs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-4.21 |
|
@sjhala-ccs: #104654 failed to apply on top of branch "enterprise-4.17": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sjhala-ccs: #104654 failed to apply on top of branch "enterprise-4.18": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sjhala-ccs: #104654 failed to apply on top of branch "enterprise-4.19": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sjhala-ccs: new pull request created: #104866 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sjhala-ccs: new pull request created: #104867 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Manual cherry-picks:
|
Version(s): 4.17+
Issue: CNV-76050
Link to docs preview: Configuring higher VM workload density (with
Pod eviction conditions used by wasp-agenttopic removed)QE review: