Skip to content

Conversation

@jneczypor
Copy link
Contributor

@jneczypor jneczypor commented Nov 20, 2025

OSDOCS-16580: Address Vale warnings and errors in "Upgrading"

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/OSDOCS-16580

Link to docs preview:
https://102886--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/upgrading/rosa-hcp-upgrading.html

QE review:
No QE needed

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2025

@jneczypor: This pull request references OSDOCS-16580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

OSDOCS-16580: Address Vale warnings and errors in "Upgrading"

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/OSDOCS-16580

Link to docs preview:

QE review:
No QE needed

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2025

@jneczypor: This pull request references OSDOCS-16580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

OSDOCS-16580: Address Vale warnings and errors in "Upgrading"

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/OSDOCS-16580

Link to docs preview:

QE review:
No QE needed

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 20, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 21, 2025

🤖 Sat Nov 22 01:50:16 - Prow CI generated the docs preview:

https://102886--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/upgrading/rosa-hcp-upgrading.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2025

@jneczypor: This pull request references OSDOCS-16580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

OSDOCS-16580: Address Vale warnings and errors in "Upgrading"

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/OSDOCS-16580

Link to docs preview:
https://102886--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/upgrading/rosa-hcp-upgrading.html

QE review:
No QE needed

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small things that I caught.

+
ifeval::["{context}" != "rosa-hcp-upgrading-whole-cluster"]
.Example output
*Example output*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a + to fix this:

Image

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 22, 2025

@jneczypor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 branch/enterprise-4.21 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants