OSDOCS 17238 Update MCO to reflect API changes made for Status Reporting #102021
Conversation
openshift-ci
bot
added
the
size/M
mburke5678
force-pushed
the
mco-mcn-for-ocl
branch
from
b4c89b1 to
de8ee3c
Compare
|
@isabella-janssen Can you PTAL? |
isabella-janssen
left a comment
isabella-janssen
left a comment
There was a problem hiding this comment.
/lgtm
Thanks @mburke5678!
|
@sergiordlr PTAL |
|
@ptalgulk01 Can you PTAL? |
|
New changes are detected. LGTM label has been removed. |
openshift-merge-robot
added
the
needs-rebase
mburke5678
force-pushed
the
mco-mcn-for-ocl
branch
from
eee733e to
9a2b983
Compare
openshift-merge-robot
removed
the
needs-rebase
|
Hello @isabella-janssen , do we need to specify that to see the OCL images status update in MCN too, we need to have TechPreview |
|
Hi @ptalgulk01, good catch. The TP warning does not seem to note that the config image values are also only TP. Would you be able to include that, @mburke5678? 
|
openshift-ci
bot
added
size/L
|
@ptalgulk01 @isabella-janssen I added the requirement to enable TP feature gates in commit e5509e1. Thank you!! |
|
looks good, Thankyou for taking a look! |
mburke5678
added
the
merge-review-needed
JoeAldinger
added
merge-review-in-progress
JoeAldinger
left a comment
JoeAldinger
left a comment
There was a problem hiding this comment.
A few suggestions, wasn't sure about CQA stuff in new PRs like this but I noted them just in case.
| Desired Image: image-registry.openshift-image-registry.svc:5000/openshift-machine-config-operator/ocb-image@sha256:b485378fd8f7963ed74f14ce64f4f1e511e1601d49302b3046b1b78a83f539e3 | ||
| # ... | ||
| ---- | ||
| <1> Digested image pull spec for the new custom layered image. |
There was a problem hiding this comment.
I think we need to be doing one of these now for callouts: https://redhat-documentation.github.io/supplementary-style-guide/#explain-commands-variables-in-code-blocks
| observedGeneration: 4 | ||
| ---- | ||
| <1> The `MachineConfigNode` object name. | ||
| <2> The new machine configuration. This field updates after the MCO validates the machine config in the `UPDATEPREPARED` phase, then the status adds the new configuration. |
There was a problem hiding this comment.
I'm not sure if you want to address the CQA 2.0 guidance in this PR or not but callouts are present in multiple modules.
There was a problem hiding this comment.
@JoeAldinger My sense is to not make CQA changes in a feature PR. My thought is that I want to focus the reviewer's attention on the changes related to the feature. Maybe my sense is off, if reviewers are going to be looking at CQA changes anyway. You are not the first. Hmmmm.
| * xref:../nodes/clusters/nodes-cluster-enabling-features.adoc#nodes-cluster-enabling[Enabling features using feature gates] | ||
| include::modules/checking-mco-node-status-configuring.adoc[leveloffset=+2] | ||
|
|
mburke5678
removed
the
merge-review-in-progress
mburke5678
force-pushed
the
mco-mcn-for-ocl
branch
from
e5509e1 to
5f17956
Compare
| @@ -0,0 +1,37 @@ | |||
| // Text snippet included in the following modules: | |||
There was a problem hiding this comment.
🤖 [error] OpenShiftAsciiDoc.ModuleContainsContentType: Module is missing the '_mod-docs-content-type' variable.
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
7 participants
https://issues.redhat.com/browse/OSDOCS-17238
Link to docs preview:
Machine creation overview -> About checking machine config node status -- Added
ImagePulledFromRegistrycondition with TP snippet, Example machine config node output and preceding paragraph with TP snippet, and Additional Resource links.Image mode for OpenShift -> Using the on-cluster image mode to apply a custom layered image -- Added verification step 4 with TP snippet, and Additional Resource link to the Feature Gate assembly.
QE review: