Conversation
This PR modifies the `set_default_api_url` function to use `context.default_api_server` instead of `context.default_api_url`. The `default_api_url` attribute does not exist in the `context` object, and is not used anywhere else in the code. However, `context.default_api_server` is used in `Context#get_api_url`. == Alternative solution Modify the `ThreadLocalContext` class to use `api_url` instead of `default_api_server` (to be consisten, we should also rename the `OPENSHIFT_CLIENT_PYTHON_DEFAULT_API_SERVER` variable to `OPENSHIFT_CLIENT_PYTHON_DEFAULT_API_URL`. Let me know if you prefer this solution.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jramcast The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @jramcast. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bradmwilliams: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
This PR modifies the
set_default_api_urlfunction to usecontext.default_api_serverinstead ofcontext.default_api_url.The
default_api_urlattribute does not exist in thecontextobject, and is not used anywhere else in the code. However,context.default_api_serveris used inContext#get_api_url.Alternative solution
Modify the
ThreadLocalContextclass to useapi_urlinstead ofdefault_api_server(to be consistent, we should also rename theOPENSHIFT_CLIENT_PYTHON_DEFAULT_API_SERVERvariable toOPENSHIFT_CLIENT_PYTHON_DEFAULT_API_URL. TheContext#get_api_urlmethod should be updated too.Let me know if you prefer this solution.