OCPBUGS-109669: Fix pre-existing unit test failures on release-4.18

[MrSanketkumar]

Summary

Fixes a pre-existing unit test failures in pkg/helpers/newapp/newapptest
that block all PRs on release-4.18.
fixes align with changes already applied on the main branch.

Changes

1. Fix TestNewAppRunAll/app_generation_using_context_dir

The test clones openshift/sti-ruby and references
ContextDir: "3.1/test/rack-test-app", but the 3.1/ directory was
removed from the upstream repository.

Fix: Update ContextDir from "3.1/test/rack-test-app" to
"3.3/test/rack-test-app" in pkg/helpers/newapp/newapptest/newapp_test.go.

References

Summary by CodeRabbit

• Bug Fixes
  • Updated the context-directory integration test to use the current Rack test application version, improving test reliability.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0e6a777e-36f4-46b0-9423-dc95bfc01425

📥 Commits

Reviewing files that changed from the base of the PR and between 6febe61 and a6e0ba0.

📒 Files selected for processing (1)

• pkg/helpers/newapp/newapptest/newapp_test.go

---

Walkthrough

The successful context-directory integration test now references 3.3/test/rack-test-app instead of 3.1/test/rack-test-app.

Changes

Context-directory integration test

Layer / File(s)	Summary
Update test reference pkg/helpers/newapp/newapptest/newapp_test.go	The successful context-directory test uses the 3.3/test/rack-test-app path.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a6e0b

This updates the test context directory used by the affected unit test without changing product behavior; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: gabemontero, ingvagabund

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: fixing pre-existing test failures on the release-4.18 branch.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The parent diff changes only ContextDir; the subtest title remains the static "app generation using context dir", and no Ginkgo title changes.
Test Structure And Quality	✅ Passed	The PR changes only a ContextDir string in a standard Go table test; the package has no Ginkgo hooks, cluster waits, resource setup, or new assertions.
Microshift Test Compatibility	✅ Passed	The commit changes one ContextDir string in a Go testing.TestNewAppRunAll unit test; it adds no Ginkgo e2e test or MicroShift-sensitive test behavior.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes one ContextDir string in a standard Go unit/integration test; it adds no Ginkgo e2e test or multi-node assumption.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff changes only a test ContextDir string from 3.1 to 3.3; it adds no deployment, operator, controller, or scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a ContextDir string inside TestNewAppRunAll; the diff adds no process-level code or stdout write, and the changed file has no main or suite setup.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff changes only an existing Go testing test's ContextDir; it adds no Ginkgo e2e test or IPv4 assumption. The GitHub source URL and external-Git behavior predate the PR.
No-Weak-Crypto	✅ Passed	The only change is a test ContextDir literal from 3.1 to 3.3; the diff and target file contain no weak-crypto algorithms, crypto APIs, or secret comparisons.
Container-Privileges	✅ Passed	The diff changes only one Go test ContextDir string and adds no manifests or privilege-related settings.
No-Sensitive-Data-In-Logs	✅ Passed	The parent-to-HEAD diff changes only a ContextDir path from 3.1 to 3.3; it adds no logging or sensitive-data output.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[MrSanketkumar]

/pipeline required

[openshift-merge-bot]

Scheduling required tests:
/test e2e-agnostic-ovn-cmd
/test e2e-aws-ovn
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-upgrade

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-builds

[MrSanketkumar]

/retitle OCPBUGS-109669: Fix pre-existing unit test failures on release-4.18

[openshift-ci-robot]

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-109669, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Fixes a pre-existing unit test failures in pkg/helpers/newapp/newapptest
that block all PRs on release-4.18.
fixes align with changes already applied on the main branch.

Changes

1. Fix TestNewAppRunAll/app_generation_using_context_dir

The test clones openshift/sti-ruby and references
ContextDir: "3.1/test/rack-test-app", but the 3.1/ directory was
removed from the upstream repository.

Fix: Update ContextDir from "3.1/test/rack-test-app" to
"3.3/test/rack-test-app" in pkg/helpers/newapp/newapptest/newapp_test.go.

References

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[MrSanketkumar]

/jira refresh

[openshift-ci-robot]

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-109669, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-105503 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-105503 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
• bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[MrSanketkumar]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[openshift-ci-robot]

@MrSanketkumar: This pull request references Jira Issue OCPBUGS-109669, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-105503 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-105503 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
• bug has dependents

Details

In response to this:

Summary

Fixes a pre-existing unit test failures in pkg/helpers/newapp/newapptest
that block all PRs on release-4.18.
fixes align with changes already applied on the main branch.

Changes

1. Fix TestNewAppRunAll/app_generation_using_context_dir

The test clones openshift/sti-ruby and references
ContextDir: "3.1/test/rack-test-app", but the 3.1/ directory was
removed from the upstream repository.

Fix: Update ContextDir from "3.1/test/rack-test-app" to
"3.3/test/rack-test-app" in pkg/helpers/newapp/newapptest/newapp_test.go.

References

Summary by CodeRabbit

• Bug Fixes
• Updated the context-directory integration test to use the current Rack test application version, improving test reliability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@MrSanketkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	a6e0ba0	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[MrSanketkumar]

/retest-required

[germanparente]

/label approved
/label backport-risk-assessed

[germanparente]

/lgtm
/verified by CI

[openshift-ci-robot]

@germanparente: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-agnostic-ovn-cmd
/test e2e-aws-ovn
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-upgrade

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-builds

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: germanparente, MrSanketkumar
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment