OCPBUGS-94044,OCPBUGS-86046: DS Merge 07/24/2026 - #335
Conversation
CRI-O 1.34+ enforces short name mode by default, which refuses to pull images with unqualified names like 'alpine' because they are ambiguous. Use a full image docker.io/library/alpine Fixes #1471 Signed-off-by: Ram Lavi <ralavi@redhat.com>
CRI-O 1.34+ enforces short name mode by default, which refuses to pull images with unqualified names like 'centos:8' because they are ambiguous. Use the full image quay.io/centos/centos:8 Fixes #1471 Signed-off-by: Ram Lavi <ralavi@redhat.com>
CRI-O 1.34+ enforces short name mode by default, which refuses to pull images with unqualified names like 'ubuntu:22.04' because they are ambiguous. Use the full image docker.io/library/ubuntu:22.04 Fixes #1471 Signed-off-by: Ram Lavi <ralavi@redhat.com>
The trivy-action@0.29.0 was trying to install Trivy v0.57.1 which no longer exists in the GitHub releases. This was causing all PR builds to fail on the "Image thick plugin" job. Update to v0.35.0 which properly installs the latest Trivy version. Assisted by Claude Sonnet 4.5 Signed-off-by: Benjamin Pickard <bpickard@redhat.com>
ci: update trivy-action to v0.35.0 to fix image scanning failure
Signed-off-by: Ying Wang <yingwang@rehat.com>
Signed-off-by: Ying Wang <yingwang@rehat.com>
…00_test.go Signed-off-by: Ying Wang <yingwang@rehat.com>
Signed-off-by: Ying Wang <yingwang@rehat.com>
When a namespace uses a primary User-Defined Network (UDN) with a device-plugin resource (e.g. SR-IOV), OVN-Kubernetes uses the last device in the list for the primary interface while Multus assigns earlier devices to cluster-default/secondary interfaces. The kubelet and checkpoint paths build the list from map iteration, so order was non-deterministic and the "last" device could differ between callers. Sorting ensures both Multus and OVN-K8s see the same order so the last device is consistently the one reserved for the primary UDN. Signed-off-by: Yun Zhou <yunz@nvidia.com>
Sort DeviceIDs in GetPodResourceMap for deterministic ordering
…ation Listing all pods across all namespaces during bootstrap is expensive in large clusters and unnecessary since the result is discarded. Use the lightweight /version endpoint to validate connectivity instead. Signed-off-by: Peng Liu <pliu@redhat.com>
Validate the per-node kubeconfig when a current certificate is available and fall back to the bootstrap kubeconfig only when the per-node config is no longer trusted. Also rebuild the derived per-node rest.Config from the reloaded bootstrap config so TLS settings are preserved and refreshed consistently. Signed-off-by: Peng Liu <pliu@redhat.com>
STATUS and GC are plugin-level commands with no pod context per the CNI 1.1.0 spec. The thick plugin daemon incorrectly required CNI_CONTAINERID, CNI_NETNS, and K8S_POD_NAME/K8S_POD_NAMESPACE for these commands, causing failures when invoked by kubelet. Signed-off-by: Jason Kary <jkary@redhat.com>
- Check os.OpenFile error in STATUS/GC test - Document that k8sArgs may be nil for STATUS/GC in HandleCNIRequest Made-with: Cursor
Bump multus-cni to Kube 1.35 and Go to 1.25
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.73.0 to 1.79.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.73.0...v1.79.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
k8sclient: use ServerVersion instead of pod list for kubeconfig validation
Fix thick plugin STATUS and GC handling for plugin-level commands
Add "nad" as shortName
e2e: Use fully qualified image name for images
…les/google.golang.org/grpc-1.79.3 Bump google.golang.org/grpc from 1.73.0 to 1.79.3
Pin GH Actions to commit sha
Add pprof profiling endpoints to the metrics server, gated behind a new EnablePprof config field. When enabled, standard Go pprof handlers are registered on the metrics port under /debug/pprof/. This also improves the metrics server setup: - Use dedicated http.ServeMux instead of DefaultServeMux - Move mux/handler setup outside the retry loop - Use http.Server with ReadHeaderTimeout for resource safety - Add graceful shutdown on context cancellation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Benjamin Pickard <bpickard@redhat.com>
Co-authored-by: Takanori Hirano <me@hrntknr.net>
Add optional pprof endpoint support to multus-daemon
Add connection limit for thick daemon.
Will do after on Upstream, not this Downstream sync. |
|
/retitle OCPBUGS-94044,OCPBUGS-86046: DS Merge 07/24/2026 |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@wizhaoredhat: This pull request references Jira Issue OCPBUGS-94044, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-86046, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@wizhaoredhat: This pull request references Jira Issue OCPBUGS-94044, which is valid. 3 validation(s) were run on this bug
This pull request references Jira Issue OCPBUGS-86046, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
openshift-ci
Bot
added
the
approved
|
/verified |
|
@wizhaoredhat: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raphaelvrosa, SchSeba, wizhaoredhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
All tests in https://github.com/openshift/openshift-tests-private/blob/main/test/extended/networking/multus.go pass in ClusterBot AWS. /verified by @wizhaoredhat |
openshift-ci-robot
added
the
verified
|
@wizhaoredhat: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wizhaoredhat: Jira Issue Verification Checks: Jira Issue OCPBUGS-94044 Jira Issue OCPBUGS-94044 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 Jira Issue Verification Checks: Jira Issue OCPBUGS-86046 Jira Issue OCPBUGS-86046 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in release 5.0.0-0.nightly-2026-07-29-000055 |
|
@wizhaoredhat https://github.com/openshift/multus-cni/pull/335#issuecomment-5074696645 was this test fixed ? I had created a followup PR for fixing the issue which security test found here in the u/s multus-cni k8snetworkplumbingwg/multus-cni#1524 cc @bpickard22 |
18 participants
OpenShift Specific
Platform & dependencies
v0.35.2→v0.36.21.25.7→1.26.0golang.org/x/*, prometheus, protobuf, etc.)Features
resource.k8s.io/v1) via newpkg/draclient:multus-daemonBug fixes
cniVersioninjection soDELdoes not leak IPs (upstream #1521)ignoreReadinessIndicatorbeing silently skipped when server config is unsetdraclient(1.36 alignment)Docs / manifests / CI
Summary by CodeRabbit
New Features
nadshorthand for NetworkAttachmentDefinitions and permissions for DRA resources.Bug Fixes
Documentation